• Russ Cox's avatar
    undo CL 131750044 / 2d6d44ceb80e · 2d53d6b5
    Russ Cox authored
    Breaks reading from stdin in parent after exec with SysProcAttr{Setpgid: true}.
    
    package main
    
    import (
            "fmt"
            "os"
            "os/exec"
            "syscall"
    )
    
    func main() {
            cmd := exec.Command("true")
            cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
            cmd.Run()
    
            fmt.Printf("Hit enter:")
            os.Stdin.Read(make([]byte, 100))
            fmt.Printf("Bye\n")
    }
    
    In go1.3, I type enter at the prompt and the program exits.
    With the CL being rolled back, the program wedges at the
    prompt.
    
    ««« original CL description
    syscall: SysProcAttr job control changes
    
    Making the child's process group the foreground process group and
    placing the child in a specific process group involves co-ordination
    between the parent and child that must be done post-fork but pre-exec.
    
    LGTM=iant
    R=golang-codereviews, gobot, iant, mikioh.mikioh
    CC=golang-codereviews
    https://golang.org/cl/131750044
    
    »»»
    
    LGTM=minux, dneil
    R=dneil, minux
    CC=golang-codereviews, iant, michael.p.macinnis
    https://golang.org/cl/174450043
    2d53d6b5
Name
Last commit
Last update
..
asm.s Loading commit data...
asm_darwin_386.s Loading commit data...
asm_darwin_amd64.s Loading commit data...
asm_dragonfly_386.s Loading commit data...
asm_dragonfly_amd64.s Loading commit data...
asm_freebsd_386.s Loading commit data...
asm_freebsd_amd64.s Loading commit data...
asm_freebsd_arm.s Loading commit data...
asm_linux_386.s Loading commit data...
asm_linux_amd64.s Loading commit data...
asm_linux_arm.s Loading commit data...
asm_nacl_386.s Loading commit data...
asm_nacl_amd64p32.s Loading commit data...
asm_nacl_arm.s Loading commit data...
asm_netbsd_386.s Loading commit data...
asm_netbsd_amd64.s Loading commit data...
asm_netbsd_arm.s Loading commit data...
asm_openbsd_386.s Loading commit data...
asm_openbsd_amd64.s Loading commit data...
asm_plan9_386.s Loading commit data...
asm_plan9_amd64.s Loading commit data...
asm_solaris_amd64.s Loading commit data...
bpf_bsd.go Loading commit data...
creds_test.go Loading commit data...
dir_plan9.go Loading commit data...
dll_windows.go Loading commit data...
env_plan9.go Loading commit data...
env_unix.go Loading commit data...
env_windows.go Loading commit data...
exec_bsd.go Loading commit data...
exec_linux.go Loading commit data...
exec_plan9.go Loading commit data...
exec_solaris.go Loading commit data...
exec_unix.go Loading commit data...
exec_windows.go Loading commit data...
export_test.go Loading commit data...
fd_nacl.go Loading commit data...
flock.go Loading commit data...
flock_linux_32bit.go Loading commit data...
fs_nacl.go Loading commit data...
lsf_linux.go Loading commit data...
mkall.sh Loading commit data...
mkall_windows.bat Loading commit data...
mkerrors.sh Loading commit data...
mksyscall.pl Loading commit data...
mksyscall_solaris.pl Loading commit data...
mksyscall_windows.go Loading commit data...
mksysctl_openbsd.pl Loading commit data...
mksysnum_darwin.pl Loading commit data...
mksysnum_dragonfly.pl Loading commit data...
mksysnum_freebsd.pl Loading commit data...
mksysnum_linux.pl Loading commit data...
mksysnum_netbsd.pl Loading commit data...
mksysnum_openbsd.pl Loading commit data...
mksysnum_plan9.sh Loading commit data...
mmap_unix_test.go Loading commit data...
net_nacl.go Loading commit data...
netlink_linux.go Loading commit data...
race.go Loading commit data...
race0.go Loading commit data...
route_bsd.go Loading commit data...
route_darwin.go Loading commit data...
route_dragonfly.go Loading commit data...
route_freebsd.go Loading commit data...
route_freebsd_32bit.go Loading commit data...
route_freebsd_64bit.go Loading commit data...
route_netbsd.go Loading commit data...
route_openbsd.go Loading commit data...
security_windows.go Loading commit data...
so_solaris.go Loading commit data...
sockcmsg_linux.go Loading commit data...
sockcmsg_unix.go Loading commit data...
srpc_nacl.go Loading commit data...
str.go Loading commit data...
syscall.go Loading commit data...
syscall_bsd.go Loading commit data...
syscall_bsd_test.go Loading commit data...
syscall_darwin.go Loading commit data...
syscall_darwin_386.go Loading commit data...
syscall_darwin_amd64.go Loading commit data...
syscall_dragonfly.go Loading commit data...
syscall_dragonfly_386.go Loading commit data...
syscall_dragonfly_amd64.go Loading commit data...
syscall_freebsd.go Loading commit data...
syscall_freebsd_386.go Loading commit data...
syscall_freebsd_amd64.go Loading commit data...
syscall_freebsd_arm.go Loading commit data...
syscall_linux.go Loading commit data...
syscall_linux_386.go Loading commit data...
syscall_linux_amd64.go Loading commit data...
syscall_linux_arm.go Loading commit data...
syscall_nacl.go Loading commit data...
syscall_nacl_386.go Loading commit data...
syscall_nacl_amd64p32.go Loading commit data...
syscall_nacl_arm.go Loading commit data...
syscall_netbsd.go Loading commit data...
syscall_netbsd_386.go Loading commit data...
syscall_netbsd_amd64.go Loading commit data...
syscall_netbsd_arm.go Loading commit data...
syscall_no_getwd.go Loading commit data...
syscall_openbsd.go Loading commit data...
syscall_openbsd_386.go Loading commit data...
syscall_openbsd_amd64.go Loading commit data...
syscall_plan9.go Loading commit data...
syscall_solaris.go Loading commit data...
syscall_solaris_amd64.go Loading commit data...
syscall_test.go Loading commit data...
syscall_unix.go Loading commit data...
syscall_unix_test.go Loading commit data...
syscall_windows.go Loading commit data...
syscall_windows_386.go Loading commit data...
syscall_windows_amd64.go Loading commit data...
syscall_windows_test.go Loading commit data...
tables_nacl.go Loading commit data...
time_nacl_386.s Loading commit data...
time_nacl_amd64p32.s Loading commit data...
time_nacl_arm.s Loading commit data...
types_darwin.go Loading commit data...
types_dragonfly.go Loading commit data...
types_freebsd.go Loading commit data...
types_linux.go Loading commit data...
types_netbsd.go Loading commit data...
types_openbsd.go Loading commit data...
types_plan9.c Loading commit data...
types_solaris.go Loading commit data...
unzip_nacl.go Loading commit data...
zerrors_darwin_386.go Loading commit data...
zerrors_darwin_amd64.go Loading commit data...
zerrors_dragonfly_386.go Loading commit data...
zerrors_dragonfly_amd64.go Loading commit data...
zerrors_freebsd_386.go Loading commit data...
zerrors_freebsd_amd64.go Loading commit data...
zerrors_freebsd_arm.go Loading commit data...
zerrors_linux_386.go Loading commit data...
zerrors_linux_amd64.go Loading commit data...
zerrors_linux_arm.go Loading commit data...
zerrors_netbsd_386.go Loading commit data...
zerrors_netbsd_amd64.go Loading commit data...
zerrors_netbsd_arm.go Loading commit data...
zerrors_openbsd_386.go Loading commit data...
zerrors_openbsd_amd64.go Loading commit data...
zerrors_plan9_386.go Loading commit data...
zerrors_plan9_amd64.go Loading commit data...
zerrors_solaris_amd64.go Loading commit data...
zerrors_windows.go Loading commit data...
zerrors_windows_386.go Loading commit data...
zerrors_windows_amd64.go Loading commit data...
zsyscall_darwin_386.go Loading commit data...
zsyscall_darwin_amd64.go Loading commit data...
zsyscall_dragonfly_386.go Loading commit data...
zsyscall_dragonfly_amd64.go Loading commit data...
zsyscall_freebsd_386.go Loading commit data...
zsyscall_freebsd_amd64.go Loading commit data...
zsyscall_freebsd_arm.go Loading commit data...
zsyscall_linux_386.go Loading commit data...
zsyscall_linux_amd64.go Loading commit data...
zsyscall_linux_arm.go Loading commit data...
zsyscall_nacl_386.go Loading commit data...
zsyscall_nacl_amd64p32.go Loading commit data...
zsyscall_nacl_arm.go Loading commit data...
zsyscall_netbsd_386.go Loading commit data...
zsyscall_netbsd_amd64.go Loading commit data...
zsyscall_netbsd_arm.go Loading commit data...
zsyscall_openbsd_386.go Loading commit data...
zsyscall_openbsd_amd64.go Loading commit data...
zsyscall_plan9_386.go Loading commit data...
zsyscall_plan9_amd64.go Loading commit data...
zsyscall_solaris_amd64.go Loading commit data...
zsyscall_windows.go Loading commit data...
zsysctl_openbsd.go Loading commit data...
zsysnum_darwin_386.go Loading commit data...
zsysnum_darwin_amd64.go Loading commit data...
zsysnum_dragonfly_386.go Loading commit data...
zsysnum_dragonfly_amd64.go Loading commit data...
zsysnum_freebsd_386.go Loading commit data...
zsysnum_freebsd_amd64.go Loading commit data...
zsysnum_freebsd_arm.go Loading commit data...
zsysnum_linux_386.go Loading commit data...
zsysnum_linux_amd64.go Loading commit data...
zsysnum_linux_arm.go Loading commit data...
zsysnum_netbsd_386.go Loading commit data...
zsysnum_netbsd_amd64.go Loading commit data...
zsysnum_netbsd_arm.go Loading commit data...
zsysnum_openbsd_386.go Loading commit data...
zsysnum_openbsd_amd64.go Loading commit data...
zsysnum_plan9_386.go Loading commit data...
zsysnum_plan9_amd64.go Loading commit data...
zsysnum_solaris_amd64.go Loading commit data...
zsysnum_windows_386.go Loading commit data...
zsysnum_windows_amd64.go Loading commit data...
ztypes_darwin_386.go Loading commit data...
ztypes_darwin_amd64.go Loading commit data...
ztypes_dragonfly_386.go Loading commit data...
ztypes_dragonfly_amd64.go Loading commit data...
ztypes_freebsd_386.go Loading commit data...
ztypes_freebsd_amd64.go Loading commit data...
ztypes_freebsd_arm.go Loading commit data...
ztypes_linux_386.go Loading commit data...
ztypes_linux_amd64.go Loading commit data...
ztypes_linux_arm.go Loading commit data...
ztypes_netbsd_386.go Loading commit data...
ztypes_netbsd_amd64.go Loading commit data...
ztypes_netbsd_arm.go Loading commit data...
ztypes_openbsd_386.go Loading commit data...
ztypes_openbsd_amd64.go Loading commit data...
ztypes_plan9_386.go Loading commit data...
ztypes_plan9_amd64.go Loading commit data...
ztypes_solaris_amd64.go Loading commit data...
ztypes_windows.go Loading commit data...
ztypes_windows_386.go Loading commit data...
ztypes_windows_amd64.go Loading commit data...