• Austin Clements's avatar
    runtime: prevent race between setNextBarrierPC and sigprof · a4a57bb4
    Austin Clements authored
    Currently, setNextBarrierPC manipulates the stack barriers without
    acquiring the stack barrier lock. This is mostly okay because
    setNextBarrierPC also runs synchronously on the G and prevents safe
    points, but this doesn't prevent a sigprof from occurring during a
    setNextBarrierPC and performing a traceback.
    
    Given that setNextBarrierPC simply sets one entry in the stack barrier
    array, this is almost certainly safe in reality. However, given that
    this depends on a subtle argument, which may not hold in the future,
    and that setNextBarrierPC almost never happens, making it nowhere near
    performance-critical, we can simply acquire the stack barrier lock and
    be sure that the synchronization will work.
    
    Updates #12528. For 1.5.3.
    
    Change-Id: Ife696e10d969f190157eb1cbe762a2de2ebce079
    Reviewed-on: https://go-review.googlesource.com/18022
    Run-TryBot: Austin Clements <austin@google.com>
    Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    a4a57bb4
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang.org/x/net/http2/hpack Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...