• David Glasser's avatar
    net/http: don't hang if RemoteAddr() blocks · b58515ba
    David Glasser authored
    The PROXY protocol is supported by several proxy servers such as haproxy
    and Amazon ELB.  This protocol allows services running behind a proxy to
    learn the remote address of the actual client connecting to the proxy,
    by including a single textual line at the beginning of the TCP
    connection.
    http://www.haproxy.org/download/1.5/doc/proxy-protocol.txt
    
    There are several Go libraries for this protocol (such as
    https://github.com/armon/go-proxyproto), which operate by wrapping a
    net.Conn with an implementation whose RemoteAddr method reads the
    protocol line before returning. This means that RemoteAddr is a blocking
    call.
    
    Before this change, http.Serve called RemoteAddr from the main Accepting
    goroutine, not from the per-connection goroutine. This meant that it
    would not Accept another connection until RemoteAddr returned, which is
    not appropriate if RemoteAddr needs to do a blocking read from the
    socket first.
    
    Fixes #12943.
    
    Change-Id: I1a242169e6e4aafd118b794e7c8ac45d0d573421
    Reviewed-on: https://go-review.googlesource.com/15835Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    b58515ba
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...