• Austin Clements's avatar
    runtime: document assumption about wbBufFlush argument slots · b800f202
    Austin Clements authored
    gcWriteBarrier and wbBufFlush assume that not writing to an argument
    variable is sufficient to not clobber the corresponding argument slot.
    This assumption lets us simplify the write barrier assembly code,
    speed up the flush path, and reduce the stack usage of the write
    barrier.
    
    But it is an assumption, so this CL documents it to make this clear.
    
    Alternatively, we could separate the register spill slots from the
    argument slots in the write barrier, but that loses the advantages
    above. On the other hand, it's extremely unlikely that we'll change
    the behavior of the compiler to start clobbering argument slots (if
    anything, we'd probably change it to *not* clobber argument slots even
    if you wrote to the arguments).
    
    Fixes #25512.
    
    Change-Id: Ib2cf29c0d90956ca02b997ef6e7fa56fc8044efe
    Reviewed-on: https://go-review.googlesource.com/127815Reviewed-by: 's avatarCherry Zhang <cherryyz@google.com>
    b800f202
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...