• Dmitriy Vyukov's avatar
    runtime: faster GC scan · b8fdaaf0
    Dmitriy Vyukov authored
    The change contains 3 spot optimizations to scan loop:
    1. Don't use byte vars, use uintptr's instead.
    This seems to alleviate some codegen issue,
    and alone accounts to a half of speedup.
    2. Remove bitmap cache. Currently we cache only 1 byte,
    so caching is not particularly effective anyway.
    Removal of the cache simplifies code and positively affects regalloc.
    3. Replace BitsMultiword switch with if and
    do debug checks only in Debug mode.
    I've benchmarked changes separately and ensured that
    each of them provides speedup on top of the previous one.
    This change as a whole fixes the unintentional regressions
    of scan loop that were introduced during development cycle.
    Fixes #8625.
    Fixes #8565.
    
    On go.benchmarks/garbage benchmark:
    GOMAXPROCS=1
    time:		-3.13%
    cputime:	-3.22%
    gc-pause-one:	-15.71%
    gc-pause-total:	-15.71%
    
    GOMAXPROCS=32
    time:		-1.96%
    cputime:	-4.43%
    gc-pause-one:	-6.22%
    gc-pause-total:	-6.22%
    
    LGTM=khr, rsc
    R=golang-codereviews, khr
    CC=golang-codereviews, rlh, rsc
    https://golang.org/cl/153990043
    b8fdaaf0
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal/syscall Loading commit data...
io Loading commit data...
lib9 Loading commit data...
libbio Loading commit data...
liblink Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...
sudo.bash Loading commit data...