• Austin Clements's avatar
    runtime: inform arena placement using sbrk(0) · bb6309cd
    Austin Clements authored
    On 32-bit architectures (or if we fail to map a 64-bit-style arena),
    we try to map the heap arena just above the end of the process image.
    While we can accept any address, using lower addresses is preferable
    because lower addresses cause us to map less of the heap bitmap.
    
    However, if a program is linked against C code that has global
    constructors, those constructors may call brk/sbrk to allocate memory
    (e.g., many C malloc implementations do this for small allocations).
    The brk also starts just above the process image, so this may adjust
    the brk past the beginning of where we want to put the heap arena. In
    this case, the kernel will pick a different address for the arena and
    it will usually be very high (at least, as these things go in a 32-bit
    address space).
    
    Fix this by consulting the current value of the brk and using this in
    addition to the end of the process image to compute the initial arena
    placement.
    
    This is implemented only on Linux currently, since we have no evidence
    that it's an issue on any other OSes.
    
    Fixes #19831.
    
    Change-Id: Id64b45d08d8c91e4f50d92d0339146250b04f2f8
    Reviewed-on: https://go-review.googlesource.com/39810
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    bb6309cd
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...