• Austin Clements's avatar
    runtime: fix sanity check in stackBarrier · bb6fb929
    Austin Clements authored
    stackBarrier on amd64 sanity checks that it's unwinding the correct
    entry in the stack barrier array. However, this check is wrong in two
    ways that make it unlikely to catch anything, right or wrong:
    
    1) It checks that savedLRPtr == SP, but, in fact, it should be that
       savedLRPtr+8 == SP because the RET that returned to stackBarrier
       popped the saved LR. However, we didn't notice this check was wrong
       because,
    
    2) the sense of the conditional branch is also wrong.
    
    Fix both of these.
    
    Change-Id: I38ba1f652b0168b5b2c11b81637656241262af7c
    Reviewed-on: https://go-review.googlesource.com/17039Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    bb6fb929
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang.org/x/net/http2/hpack Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...