• kirk's avatar
    database/sql: fix transaction leak · bcf964de
    kirk authored
    When the user context which passed in (*DB)BeginTx is canceled or
    timeout, the current implementation could cause db transaction leak
    in some extreme scenario.
    
    Goroutine 1:
            Call (*DB) BeginTx begins a transaction with a userContext.
            In (*DB)BeginTx, a new goroutine (*Tx)awaitDone
            which monitor context and rollback tx if needed will be created
    
    Goroutine 2(awaitDone):
            block on tx.ctx.Done()
    
    Goroutine 1:
            Execute some insert or update sqls on the database
    
    Goroutine 1:
            Commit the transaction, (*Tx)Commit set
            the atomic variable tx.done to 1
    
    Goroutine 3(maybe global timer):
            Cancel userContext which be passed in Tx
    
    Goroutine 1:
            (*Tx)Commit checks tx.ctx.Done().
            Due to the context has been canceled, it will return
            context.Canceled or context.DeadlineExceeded error immediately
            and abort the real COMMIT operation of transaction
    
    Goroutine 2:
            Release with tx.ctx.Done() signal, execute (*Tx)rollback.
            However the atomic variable tx.done is 1 currently,
            it will return ErrTxDone error immediately and
            abort the real ROLLBACK operation of transaction
    
    Fixes #22976
    
    Change-Id: I3bc23adf25db823861d91e33d3cca6189fb1171d
    Reviewed-on: https://go-review.googlesource.com/81736
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: 's avatarDaniel Theophanes <kardianos@gmail.com>
    bcf964de
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...