• Alberto Donizetti's avatar
    test/codegen: fix issue with arm64 memmove codegen test · c0289583
    Alberto Donizetti authored
    This recently added arm64 memmove codegen check:
    
      func movesmall() {
        // arm64:-"memmove"
        x := [...]byte{1, 2, 3, 4, 5, 6, 7}
        copy(x[1:], x[:])
      }
    
    is not correct, for two reasons:
    
    1. regexps are matched from the start of the disasm line (excluding
       line information). This mean that a negative -"memmove" check will
       pass against a 'CALL runtime.memmove' line because the line does
       not start with 'memmove' (its starts with CALL...).
       The way to specify no 'memmove' match whatsoever on the line is
       -".*memmove"
    
    2. AFAIK comments on their own line are matched against the first
       subsequent non-comment line. So the code above only verifies that
       the x := ... line does not generate a memmove. The comment should
       be moved near the copy() line, if it's that one we want to not
       generate a memmove call.
    
    The fact that the test above is not effective can be checked by
    running `go run run.go -v codegen` in the toplevel test directory with
    a go1.10 toolchain (that does not have the memmove-elision
    optimization). The test will still pass (it shouldn't).
    
    This change changes the regexp to -".*memmove" and moves it near the
    line it needs to (not)match.
    
    Change-Id: Ie01ef4d775e77d92dc8d8b7856b89b200f5e5ef2
    Reviewed-on: https://go-review.googlesource.com/98977
    Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarCherry Zhang <cherryyz@google.com>
    c0289583
Name
Last commit
Last update
..
bits.go Loading commit data...
issue22703.go Loading commit data...
math.go Loading commit data...
mathbits.go Loading commit data...
memcombine.go Loading commit data...
movesmall.go Loading commit data...
rotate.go Loading commit data...