• Ian Lance Taylor's avatar
    runtime: yield after raising signal that should kill process · c1b32ace
    Ian Lance Taylor authored
    Issue #15613 points out that the darwin builders have been getting
    regular failures in which a process that should exit with a SIGPIPE
    signal is instead exiting with exit status 2. The code calls
    runtime.raise. On most systems runtime.raise is the equivalent of
    pthread_kill(gettid(), sig); that is, it kills the thread with the
    signal, which should ensure that the program does not keep going. On
    darwin, however, runtime.raise is actually kill(getpid(), sig); that is,
    it sends a signal to the entire process. If the process decides to
    deliver the signal to a different thread, then it is possible that in
    some cases the thread that calls raise is able to execute the next
    system call before the signal is actually delivered. That would cause
    the observed error.
    
    I have not been able to recreate the problem myself, so I don't know
    whether this actually fixes it. But, optimistically:
    
    Fixed #15613.
    
    Change-Id: I60c0a9912aae2f46143ca1388fd85e9c3fa9df1f
    Reviewed-on: https://go-review.googlesource.com/23152
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    c1b32ace
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang.org/x/net Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...