• Russ Cox's avatar
    cmd/link: reject non-package main toplevel.a file, remove dead code · c7b1ef99
    Russ Cox authored
    The test for non-package main top-level inputs is done while parsing
    the export data. Issue #13468 happened because we were not parsing
    the export data when using compiler-generated archives
    (that is, when using go tool compile -pack).
    
    Fix this by parsing the export data even for archives.
    
    However, that turns up a different problem: the export data check
    reports (one assumes spurious) skew errors now, because it has
    not been run since Go 1.2.
    (Go 1.3 was the first release to use go tool compile -pack.)
    
    Since the code hasn't run since Go 1.2, it can't be that important.
    Since it doesn't work today, just delete it.
    
    Figuring out how to make this code work with Robert's export
    format was one of the largest remaining TODOs for that format.
    Now we don't have to.
    
    Fixes #13468 and makes the world a better place.
    
    Change-Id: I40a4b284cf140d49d48b714bd80762d6889acdb9
    Reviewed-on: https://go-review.googlesource.com/17976Reviewed-by: 's avatarRobert Griesemer <gri@golang.org>
    c7b1ef99
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang.org/x/net/http2/hpack Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...