• Austin Clements's avatar
    runtime: fix, simplify, and improve scan state in goroutine header · c7c7c703
    Austin Clements authored
    Currently goroutineheader goes through some convolutions to *almost*
    print the scan state of a G. However, the code path that would print
    the scan state of the G refers to gStatusStrings where it almost
    certainly meant to refer to gScanStatusStrings (which is unused), so
    it winds up printing the regular status string without the scan state
    either way. Furthermore, if the G is in _Gwaiting, we override the
    status string and lose where this would indicate the scan state if it
    worked.
    
    This commit fixes this so the runtime prints the scan state. However,
    rather than using a parallel list of status strings, this simply adds
    a conditional print if the scan bit is set. This lets us remove the
    string list, prints the scan state even in _Gwaiting, and lets us
    strip off the scan bit at the beginning of the function, which
    simplifies the rest of it.
    
    Change-Id: Ic0adbe5c05abf4adda93da59f93b578172b28e3d
    Reviewed-on: https://go-review.googlesource.com/18092Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    c7c7c703
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang.org/x/net/http2/hpack Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...