• Brad Fitzpatrick's avatar
    net/http/httputil: fix race/crash in previous ReverseProxy change · c870d56f
    Brad Fitzpatrick authored
    The previous ReverseProxy change, CL 137335, introduced a bug which could cause
    a race and/or a crash.
    
    This reliably crashed before:
    
    $ go test -short -race -v -run=TestReverseProxyFlushInterval -count=20 net/http/httputil
    
    The problem was a goroutine was running http.ResponseWriter.Flush
    after the http.Handler's ServeHTTP completed. There was code to
    prevent that (a deferred stop call) but the stop call didn't consider
    the case where time.AfterFunc had already fired off a new goroutine
    but that goroutine hadn't yet scheduled.
    
    Change-Id: I06357908465a3b953efc33e63c70dec19a501adf
    Reviewed-on: https://go-review.googlesource.com/c/140977
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarDmitri Shuralyov <dmitshur@golang.org>
    c870d56f
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testdata Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...