• Robert Griesemer's avatar
    cmd/compile/internal/gc: fix Node.copy and introduce (raw|sep)copy · ce58a39f
    Robert Griesemer authored
    Node.copy used to make a shallow copy of a node. Often, this is not
    correct: If a node n's Orig field pointed to itself, the copy's Orig
    field has to be adjusted to point to the copy. Otherwise, if n is
    modified later, the copy's Orig appears modified as well (because it
    points to n).
    
    This was fixed for one specific case with
    https://go-review.googlesource.com/c/go/+/136395 (issue #26855).
    
    This change instead addresses copy in general:
    
    In two cases we don't want the Orig adjustment as it causes escape
    analysis output to fail (not match the existing error messages).
    rawcopy is used in those cases.
    
    In several cases Orig is set to the copy immediately after making
    a copy; a new function sepcopy is used there.
    
    Updates #26855.
    Fixes #27765.
    
    Change-Id: Idaadeb5c4b9a027daabd46a2361348f7a93f2b00
    Reviewed-on: https://go-review.googlesource.com/136540Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
    ce58a39f
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...