• Justin Nuß's avatar
    mime: Remove an allocation in word decoding. · d0c9b409
    Justin Nuß authored
    This fixes a TODO in (*WordDecoder).Decode by replacing a call to strings.Split with
    simple prefix/suffix checking and some custom slicing.
    
    Benchmark results:
    
    benchmark                    old ns/op     new ns/op     delta
    BenchmarkQEncodeWord-8       740           693           -6.35%
    BenchmarkQDecodeWord-8       1291          727           -43.69%
    BenchmarkQDecodeHeader-8     1194          767           -35.76%
    
    benchmark                    old allocs     new allocs     delta
    BenchmarkQEncodeWord-8       1              1              +0.00%
    BenchmarkQDecodeWord-8       3              2              -33.33%
    BenchmarkQDecodeHeader-8     3              2              -33.33%
    
    benchmark                    old bytes     new bytes     delta
    BenchmarkQEncodeWord-8       48            48            +0.00%
    BenchmarkQDecodeWord-8       128           48            -62.50%
    BenchmarkQDecodeHeader-8     128           48            -62.50%
    
    Change-Id: I2d6844c75ec2e2b79be2e49b7fc4ca320b7e84e5
    Reviewed-on: https://go-review.googlesource.com/14432Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    d0c9b409
Name
Last commit
Last update
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...