• Josh Bleecher Snyder's avatar
    cmd/compile: avoid giant init functions due to many user inits · d1b544c7
    Josh Bleecher Snyder authored
    We generate code that calls each user init function one at a time.
    When there are lots of user init functions,
    usually due to generated code, like test/rotate* or
    github.com/juju/govmomi/vim25/types,
    we can end up with a giant function,
    which can be slow to compile.
    
    This CL puts in an escape valve.
    When there are more than 500 functions, instead of doing:
    
    init.0()
    init.1()
    // ...
    
    we construct a static array of functions:
    
    var fns = [...]func(){init.0, init.1, ... }
    
    and call them in a loop.
    
    This generates marginally bigger, marginally worse code,
    so we restrict it to cases in which it might start to matter.
    
    500 was selected as a mostly arbitrary threshold for "lots".
    Each call uses two Progs, one for PCDATA and one for the call,
    so at 500 calls we use ~1000 Progs.
    At concurrency==8, we get a Prog cache of about
    1000 Progs per worker.
    So a threshold of 500 should more or less avoid
    exhausting the Prog cache in most cases.
    
    Change-Id: I276b887173ddbf65b2164ec9f9b5eb04d8c753c2
    Reviewed-on: https://go-review.googlesource.com/41500Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    d1b544c7
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...