• Austin Clements's avatar
    runtime: repeat bitmap for slice of GCprog n-1 times, not n times · d231cb82
    Austin Clements authored
    Currently, to write out the bitmap of a slice of a type with a GCprog,
    we construct a new GCprog that executes the underlying type's GCprog
    to write out the bitmap once and then repeats those bits n more times.
    This results in n+1 repetitions of the bitmap, which is one more
    repetition than it should be. This corrupts the bitmap of the heap
    following the slice and may write past the mapped bitmap memory and
    segfault.
    
    Fix this by repeating the bitmap only n-1 more times.
    
    Fixes #11430.
    
    Change-Id: Ic24854363bffc5a755b66f257339f9309ada3aa5
    Reviewed-on: https://go-review.googlesource.com/11570
    Run-TryBot: Austin Clements <austin@google.com>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    d231cb82
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...