• Mikio Hara's avatar
    net: don't enclose non-literal IPv6 addresses in square brackets · dc74f51c
    Mikio Hara authored
    The net package uses various textual representations for network
    identifiers and locators on the Internet protocol suite as API.
    In fact, the representations are the composition of subset of multple
    RFCs: RFC 3986, RFC 4007, RFC 4632, RFC 4291 and RFC 5952.
    
    RFC 4007 describes guidelines for the use of textual representation of
    IPv6 addressing/routing scope zone and doesn't prohibit the format for
    implementation dependent purposes, as in, specifying a literal IPv6
    address and its connected region of routing topology as application
    user interface. However, a non-literal IPv6 address, for example, a
    host name, with a zone enclosed in square brackets confuses us because
    a zone is basically for non-global IPv6 addresses and a pair of square
    brackets is used as a set of delimiters between a literal IPv6 address
    and a service name or transport port number.
    
    To mitigate such confusion, this change makes JoinHostPort not enclose
    non-literal IPv6 addresses in square brackets and SplitHostPort accept
    the form "host%zone:port" to recommend that anything enclosed in
    square brackets should be a literal IPv6 address.
    
    Before this change:
    	JoinHostPort("name%zone", "80") = "[name%zone]:80"
    	JoinHostPort("[::1%zone]", "80") = "[::1%zone]:80"
    	SplitHostPort("name%zone:80") = "", "", "address name%zone:80: missing brackets in address"
    	SplitHostPort("[name%zone]:80") = "name%zone", "80", nil
    	SplitHostPort("[::1%zone]:80") = "::1%zone", "80", nil
    
    After this change:
    	JoinHostPort("name%zone", "80") = "name%zone:80"
    	JoinHostPort("[::1%zone]", "80") = "[::1%zone]:80"
    	SplitHostPort("name%zone:80") = "name%zone", "80", nil
    	SplitHostPort("[name%zone]:80") = "name%zone", "80", nil // for backwards compatibility
    	SplitHostPort("[::1%zone]:80") = "::1%zone", "80", nil
    
    Also updates docs and test cases on SplitHostPort and JoinHostPort for
    clarification.
    
    Fixes #18059.
    Fixes #18060.
    
    Change-Id: I5c3ccce4fa0fbdd58f698fc280635ea4a14d2a37
    Reviewed-on: https://go-review.googlesource.com/40510
    Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    dc74f51c
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...