• Keith Randall's avatar
    cmd/compile: use masks instead of branches for slicing · deb4177c
    Keith Randall authored
    When we do
    
      var x []byte = ...
      y := x[i:]
    
    We can't just use y.ptr = x.ptr + i, as the new pointer may point to the
    next object in memory after the backing array.
    We used to fix this by doing:
    
      y.cap = x.cap - i
      delta := i
      if y.cap == 0 {
        delta = 0
      }
      y.ptr = x.ptr + delta
    
    That generates a branch in what is otherwise straight-line code.
    
    Better to do:
    
      y.cap = x.cap - i
      mask := (y.cap - 1) >> 63 // -1 if y.cap==0, 0 otherwise
      y.ptr = x.ptr + i &^ mask
    
    It's about the same number of instructions (~4, depending on what
    parts are constant, and the target architecture), but it is all
    inline. It plays nicely with CSE, and the mask can be computed
    in parallel with the index (in cases where a multiply is required).
    
    It is a minor win in both speed and space.
    
    Change-Id: Ied60465a0b8abb683c02208402e5bb7ac0e8370f
    Reviewed-on: https://go-review.googlesource.com/32022
    Run-TryBot: Keith Randall <khr@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarCherry Zhang <cherryyz@google.com>
    deb4177c
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...