• Keith Randall's avatar
    cmd/compile: mark modify ops as both read and write · dffc915b
    Keith Randall authored
    If the modify ops operate on a variable, we should tell the liveness
    pass that the variable is still live before the instruction.
    
    This looks like a bug, but I don't think there's any way to trigger
    it at the moment. It only matters for pointer-containing values, and
    the modify ops don't normally work on pointers. Even when I reach for
    unsafe.Pointer tricks, I can't get ADDLmodify to work on pointers, as
    there's always a Convert or VarDef preventing the coalescing.
    
    TL;DR I can't figure out a test for this. But we should probably
    fix it anyway.
    
    Change-Id: I971c62616dec51a33788b7634e6478e1bfcd6260
    Reviewed-on: https://go-review.googlesource.com/112157Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    dffc915b
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...