• Austin Clements's avatar
    runtime: hide <autogenerated> methods from call stack · e9720951
    Austin Clements authored
    The compiler generates wrapper methods to forward interface method
    calls (which are always pointer-based) to value methods. These
    wrappers appear in the call stack even though they are an
    implementation detail. This leaves ugly "<autogenerated>" functions in
    stack traces and can throw off skip counts for stack traces.
    
    Fix this by considering these runtime frames in printed stack traces
    so they will only be printed if runtime frames are being printed, and
    by eliding them from the call stack expansion used by CallersFrames
    and Caller.
    
    This removes the test for issue 4388 since that was checking that
    "<autogenerated>" appeared in the stack trace instead of something
    even weirder. We replace it with various runtime package tests.
    
    Fixes #16723.
    
    Change-Id: Ice3f118c66f254bb71478a664d62ab3fc7125819
    Reviewed-on: https://go-review.googlesource.com/45412
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    e9720951
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...