• Brad Fitzpatrick's avatar
    net/http: make Transport.RoundTrip return raw Conn.Read error on peek failure · ea2376fc
    Brad Fitzpatrick authored
    From at least Go 1.4 to Go 1.6, Transport.RoundTrip would return the
    error value from net.Conn.Read directly when the initial Read (1 byte
    Peek) failed while reading the HTTP response, if a request was
    outstanding. While never a documented or tested promise, Go 1.7 changed the
    behavior (starting at https://golang.org/cl/23160).
    
    This restores the old behavior and adds a test (but no documentation
    promises yet) while keeping the fix for spammy logging reported in #15446.
    
    This looks larger than it is: it just changes errServerClosedConn from
    a variable to a type, where the type preserves the underlying
    net.Conn.Read error, for unwrapping later in Transport.RoundTrip.
    
    Fixes #16465
    
    Change-Id: I6fa018991221e93c0cfe3e4129cb168fbd98bd27
    Reviewed-on: https://go-review.googlesource.com/25153Reviewed-by: 's avatarAndrew Gerrand <adg@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    ea2376fc
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x/net Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...