• Alberto Donizetti's avatar
    math/big: protect against aliasing in nat.divLarge · ff534e21
    Alberto Donizetti authored
    In nat.divLarge (having signature (z nat).divLarge(u, uIn, v nat)),
    we check whether z aliases uIn or v, but aliasing is currently not
    checked for the u parameter.
    
    Unfortunately, z and u aliasing each other can in some cases cause
    errors in the computation.
    
    The q return parameter (which will hold the result's quotient), is
    unconditionally initialized as
    
        q = z.make(m + 1)
    
    When cap(z) ≥ m+1, z.make() will reuse z's backing array, causing q
    and z to share the same backing array. If then z aliases u, setting q
    during the quotient computation will then corrupt u, which at that
    point already holds computation state.
    
    To fix this, we add an alias(z, u) check at the beginning of the
    function, taking care of aliasing the same way we already do for uIn
    and v.
    
    Fixes #22830
    
    Change-Id: I3ab81120d5af6db7772a062bb1dfc011de91f7ad
    Reviewed-on: https://go-review.googlesource.com/78995
    Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
    Run-TryBot: Robert Griesemer <gri@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarRobert Griesemer <gri@golang.org>
    ff534e21
Name
Last commit
Last update
..
accuracy_string.go Loading commit data...
arith.go Loading commit data...
arith_386.s Loading commit data...
arith_amd64.s Loading commit data...
arith_amd64p32.s Loading commit data...
arith_arm.s Loading commit data...
arith_arm64.s Loading commit data...
arith_decl.go Loading commit data...
arith_decl_pure.go Loading commit data...
arith_decl_s390x.go Loading commit data...
arith_mips64x.s Loading commit data...
arith_mipsx.s Loading commit data...
arith_ppc64x.s Loading commit data...
arith_s390x.s Loading commit data...
arith_s390x_test.go Loading commit data...
arith_test.go Loading commit data...
bits_test.go Loading commit data...
calibrate_test.go Loading commit data...
decimal.go Loading commit data...
decimal_test.go Loading commit data...
doc.go Loading commit data...
example_rat_test.go Loading commit data...
example_test.go Loading commit data...
float.go Loading commit data...
float_test.go Loading commit data...
floatconv.go Loading commit data...
floatconv_test.go Loading commit data...
floatexample_test.go Loading commit data...
floatmarsh.go Loading commit data...
floatmarsh_test.go Loading commit data...
ftoa.go Loading commit data...
gcd_test.go Loading commit data...
hilbert_test.go Loading commit data...
int.go Loading commit data...
int_test.go Loading commit data...
intconv.go Loading commit data...
intconv_test.go Loading commit data...
intmarsh.go Loading commit data...
intmarsh_test.go Loading commit data...
nat.go Loading commit data...
nat_test.go Loading commit data...
natconv.go Loading commit data...
natconv_test.go Loading commit data...
prime.go Loading commit data...
prime_test.go Loading commit data...
rat.go Loading commit data...
rat_test.go Loading commit data...
ratconv.go Loading commit data...
ratconv_test.go Loading commit data...
ratmarsh.go Loading commit data...
ratmarsh_test.go Loading commit data...
roundingmode_string.go Loading commit data...
sqrt.go Loading commit data...
sqrt_test.go Loading commit data...