• Dave Cheney's avatar
    runtime/cgo: encode BLX directly, fixes one clang build error on arm · d1b29137
    Dave Cheney authored
    Fixes #8348.
    
    Trying to work around clang's dodgy support for .arch by reverting to the external assembler didn't work out so well. Minux had a much better solution to encode the instructions we need as .word directives which avoids .arch altogether.
    
    I've confirmed with gdb that this form produces the expected machine code
    
    Dump of assembler code for function crosscall_arm1:
       0x00000000 <+0>:	push	{r4, r5, r6, r7, r8, r9, r10, r11, r12, lr}
       0x00000004 <+4>:	mov	r4, r0
       0x00000008 <+8>:	mov	r5, r1
       0x0000000c <+12>:	mov	r0, r2
       0x00000010 <+16>:	blx	r5
       0x00000014 <+20>:	blx	r4
       0x00000018 <+24>:	pop	{r4, r5, r6, r7, r8, r9, r10, r11, r12, pc}
    
    There is another compilation failure that blocks building Go with clang on arm
    
    # ../misc/cgo/test
    # _/home/dfc/go/misc/cgo/test
    /tmp/--407b12.s: Assembler messages:
    /tmp/--407b12.s:59: Error: selected processor does not support ARM mode `blx r0'
    clang: error: assembler command failed with exit code 1 (use -v to see invocation)
    FAIL	_/home/dfc/go/misc/cgo/test [build failed]
    
    I'll open a new issue for that
    
    LGTM=iant
    R=iant, minux
    CC=golang-codereviews
    https://golang.org/cl/158180047
    d1b29137
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal/syscall Loading commit data...
io Loading commit data...
lib9 Loading commit data...
libbio Loading commit data...
liblink Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...
sudo.bash Loading commit data...