• Daniel Martí's avatar
    cmd/vet: fix some pointer false positives in printf · edb2d1cb
    Daniel Martí authored
    fmt's godoc reads:
    
    	For compound objects, the elements are printed using these
    	rules, recursively, laid out like this:
    
    		struct:             {field0 field1 ...}
    		array, slice:       [elem0 elem1 ...]
    		maps:               map[key1:value1 key2:value2 ...]
    		pointer to above:   &{}, &[], &map[]
    
    That is, a pointer to a struct, array, slice, or map, can be correctly
    printed by fmt if the type pointed to can be printed without issues.
    
    vet was only following this rule for pointers to structs, omitting
    arrays, slices, and maps. Fix that, and add tests for all the
    combinations.
    
    Updates #27672.
    
    Change-Id: Ie61ebe1fffc594184f7b24d7dbf72d7d5de78309
    Reviewed-on: https://go-review.googlesource.com/c/147758
    Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarAlan Donovan <adonovan@google.com>
    edb2d1cb
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testdata Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...