• Austin Clements's avatar
    runtime: make GOTRACEBACK=crash crash promptly in cgo binaries · f2e87158
    Austin Clements authored
    GOTRACEBACK=crash works by bouncing a SIGQUIT around the process
    sched.mcount times. However, sched.mcount includes the extra Ms
    allocated by oneNewExtraM for cgo callbacks. Hence, if there are any
    extra Ms that don't have real OS threads, we'll try to send SIGQUIT
    more times than there are threads to catch it. Since nothing will
    catch these extra signals, we'll fall back to blocking for five
    seconds before aborting the process.
    
    Avoid this five second delay by subtracting out the number of extra Ms
    when sending SIGQUITs.
    
    Of course, in a cgo binary, it's still possible for the SIGQUIT to go
    to a cgo thread and cause some other failure mode. This does not fix
    that.
    
    Change-Id: I4fbf3c52dd721812796c4c1dcb2ab4cb7026d965
    Reviewed-on: https://go-review.googlesource.com/38182
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    f2e87158
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...