• Taru Karttunen's avatar
    os: reduce allocations in Readdir on unix · f5f480e1
    Taru Karttunen authored
    Include syscall.Stat_t on unix to the
    unexported fileStat structure rather than
    accessing it though an interface.
    
    Additionally add a benchmark for Readdir
    (and Readdirnames).
    
    Tested on linux, freebsd, netbsd, openbsd
    darwin, solaris, does not touch windows
    stuff. Does not change the API, as
    discussed on golang-dev.
    
    E.g. on linux/amd64 with a directory of 65 files:
    
    benchmark              old ns/op     new ns/op     delta
    BenchmarkReaddir-4     67774         66225         -2.29%
    
    benchmark              old allocs     new allocs     delta
    BenchmarkReaddir-4     334            269            -19.46%
    
    benchmark              old bytes     new bytes     delta
    BenchmarkReaddir-4     25208         24168         -4.13%
    
    Change-Id: I44ef72a04ad7055523a980f29aa11122040ae8fe
    Reviewed-on: https://go-review.googlesource.com/16423Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    f5f480e1
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang.org/x/net/http2/hpack Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...