Commit 0525486b authored by Taylor Thomas's avatar Taylor Thomas Committed by GitHub

Merge pull request #2497 from tyrannasaurusbanks/master

Add check to stop helm 'waiting' for external services to become ready
parents 3ed1ccf5 b4fc1c7c
......@@ -136,6 +136,11 @@ func podsReady(pods []v1.Pod) bool {
func servicesReady(svc []v1.Service) bool {
for _, s := range svc {
// ExternalName Services are external to cluster so helm shouldn't be checking to see if they're 'ready' (i.e. have an IP Set)
if s.Spec.Type == v1.ServiceTypeExternalName {
continue
}
// Make sure the service is not explicitly set to "None" before checking the IP
if s.Spec.ClusterIP != v1.ClusterIPNone && !v1.IsServiceIPSet(&s) {
return false
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment