Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
1db7bd64
Commit
1db7bd64
authored
Sep 28, 2016
by
Adam Reese
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(helm): s/version/revision/
parent
5a5a44ec
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
6 additions
and
6 deletions
+6
-6
get.go
cmd/helm/get.go
+2
-2
get_test.go
cmd/helm/get_test.go
+1
-1
list.go
cmd/helm/list.go
+1
-1
list_test.go
cmd/helm/list_test.go
+1
-1
status.go
cmd/helm/status.go
+1
-1
No files found.
cmd/helm/get.go
View file @
1db7bd64
...
...
@@ -73,7 +73,7 @@ func newGetCmd(client helm.Interface, out io.Writer) *cobra.Command {
},
}
cmd
.
PersistentFlags
()
.
Int32Var
(
&
get
.
version
,
"
version"
,
0
,
"get the named release with ver
sion"
)
cmd
.
PersistentFlags
()
.
Int32Var
(
&
get
.
version
,
"
revision"
,
0
,
"get the named release with revi
sion"
)
cmd
.
AddCommand
(
newGetValuesCmd
(
nil
,
out
))
cmd
.
AddCommand
(
newGetManifestCmd
(
nil
,
out
))
...
...
@@ -81,7 +81,7 @@ func newGetCmd(client helm.Interface, out io.Writer) *cobra.Command {
return
cmd
}
var
getTemplate
=
`
VER
SION: {{.Release.Version}}
var
getTemplate
=
`
REVI
SION: {{.Release.Version}}
RELEASED: {{.ReleaseDate}}
CHART: {{.Release.Chart.Metadata.Name}}-{{.Release.Chart.Metadata.Version}}
USER-SUPPLIED VALUES:
...
...
cmd/helm/get_test.go
View file @
1db7bd64
...
...
@@ -29,7 +29,7 @@ func TestGetCmd(t *testing.T) {
name
:
"get with a release"
,
resp
:
releaseMock
(
&
releaseOptions
{
name
:
"thomas-guide"
}),
args
:
[]
string
{
"thomas-guide"
},
expected
:
"
VER
SION: 1
\n
RELEASED: (.*)
\n
CHART: foo-0.1.0-beta.1
\n
USER-SUPPLIED VALUES:
\n
name:
\"
value
\"\n
COMPUTED VALUES:
\n
name: value
\n\n
HOOKS:
\n
---
\n
# pre-install-hook
\n
"
+
mockHookTemplate
+
"
\n
MANIFEST:"
,
expected
:
"
REVI
SION: 1
\n
RELEASED: (.*)
\n
CHART: foo-0.1.0-beta.1
\n
USER-SUPPLIED VALUES:
\n
name:
\"
value
\"\n
COMPUTED VALUES:
\n
name: value
\n\n
HOOKS:
\n
---
\n
# pre-install-hook
\n
"
+
mockHookTemplate
+
"
\n
MANIFEST:"
,
},
{
name
:
"get requires release name arg"
,
...
...
cmd/helm/list.go
View file @
1db7bd64
...
...
@@ -191,7 +191,7 @@ func (l *listCmd) statusCodes() []release.Status_Code {
func
formatList
(
rels
[]
*
release
.
Release
)
string
{
table
:=
uitable
.
New
()
table
.
MaxColWidth
=
30
table
.
AddRow
(
"NAME"
,
"
VER
SION"
,
"UPDATED"
,
"STATUS"
,
"CHART"
)
table
.
AddRow
(
"NAME"
,
"
REVI
SION"
,
"UPDATED"
,
"STATUS"
,
"CHART"
)
for
_
,
r
:=
range
rels
{
c
:=
fmt
.
Sprintf
(
"%s-%s"
,
r
.
Chart
.
Metadata
.
Name
,
r
.
Chart
.
Metadata
.
Version
)
t
:=
timeconv
.
String
(
r
.
Info
.
LastDeployed
)
...
...
cmd/helm/list_test.go
View file @
1db7bd64
...
...
@@ -45,7 +45,7 @@ func TestListCmd(t *testing.T) {
resp
:
[]
*
release
.
Release
{
releaseMock
(
&
releaseOptions
{
name
:
"atlas"
}),
},
expected
:
"NAME
\t
VERSION
\t
UPDATED
\t
STATUS
\t
CHART
\n
atlas
\t
1
\t
(.*)
\t
DEPLOYED
\t
foo-0.1.0-beta.1
\n
"
,
expected
:
"NAME
\t
REVISION
\t
UPDATED
\t
STATUS
\t
CHART
\n
atlas
\t
1
\t
(.*)
\t
DEPLOYED
\t
foo-0.1.0-beta.1
\n
"
,
},
{
name
:
"with a release, multiple flags"
,
...
...
cmd/helm/status.go
View file @
1db7bd64
...
...
@@ -60,7 +60,7 @@ func newStatusCmd(client helm.Interface, out io.Writer) *cobra.Command {
},
}
cmd
.
PersistentFlags
()
.
Int32Var
(
&
status
.
version
,
"
version"
,
0
,
"If set, display the status of the named release with ver
sion"
)
cmd
.
PersistentFlags
()
.
Int32Var
(
&
status
.
version
,
"
revision"
,
0
,
"If set, display the status of the named release with revi
sion"
)
return
cmd
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment