Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
4d1a401a
Unverified
Commit
4d1a401a
authored
Apr 27, 2018
by
Matthew Fisher
Committed by
GitHub
Apr 27, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Fix tiller deployment on RBAC clusters"
parent
2b7d216e
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
6 deletions
+1
-6
install.go
cmd/helm/installer/install.go
+1
-3
install_test.go
cmd/helm/installer/install_test.go
+0
-3
No files found.
cmd/helm/installer/install.go
View file @
4d1a401a
...
...
@@ -176,7 +176,6 @@ func generateDeployment(opts *Options) (*v1beta1.Deployment, error) {
return
nil
,
err
}
}
automountServiceAccountToken
:=
opts
.
ServiceAccount
!=
""
d
:=
&
v1beta1
.
Deployment
{
ObjectMeta
:
metav1
.
ObjectMeta
{
Namespace
:
opts
.
Namespace
,
...
...
@@ -190,8 +189,7 @@ func generateDeployment(opts *Options) (*v1beta1.Deployment, error) {
Labels
:
labels
,
},
Spec
:
v1
.
PodSpec
{
ServiceAccountName
:
opts
.
ServiceAccount
,
AutomountServiceAccountToken
:
&
automountServiceAccountToken
,
ServiceAccountName
:
opts
.
ServiceAccount
,
Containers
:
[]
v1
.
Container
{
{
Name
:
"tiller"
,
...
...
cmd/helm/installer/install_test.go
View file @
4d1a401a
...
...
@@ -96,9 +96,6 @@ func TestDeploymentManifestForServiceAccount(t *testing.T) {
if
got
:=
d
.
Spec
.
Template
.
Spec
.
ServiceAccountName
;
got
!=
tt
.
serviceAccount
{
t
.
Errorf
(
"%s: expected service account value %q, got %q"
,
tt
.
name
,
tt
.
serviceAccount
,
got
)
}
if
got
:=
*
d
.
Spec
.
Template
.
Spec
.
AutomountServiceAccountToken
;
got
!=
(
tt
.
serviceAccount
!=
""
)
{
t
.
Errorf
(
"%s: unexpected automountServiceAccountToken = %t for serviceAccount %q"
,
tt
.
name
,
got
,
tt
.
serviceAccount
)
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment