Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
6b800509
Unverified
Commit
6b800509
authored
May 07, 2019
by
Patrick Decat
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add comment to explain why the repositories file is read a second time
Signed-off-by:
Patrick Decat
<
pdecat@gmail.com
>
parent
3f3b5b42
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
1 deletion
+3
-1
repo_add.go
cmd/helm/repo_add.go
+3
-1
No files found.
cmd/helm/repo_add.go
View file @
6b800509
...
@@ -135,7 +135,7 @@ func addRepository(name, url, username, password string, home helmpath.Home, cer
...
@@ -135,7 +135,7 @@ func addRepository(name, url, username, password string, home helmpath.Home, cer
return
fmt
.
Errorf
(
"Looks like %q is not a valid chart repository or cannot be reached: %s"
,
url
,
err
.
Error
())
return
fmt
.
Errorf
(
"Looks like %q is not a valid chart repository or cannot be reached: %s"
,
url
,
err
.
Error
())
}
}
// Lock the repository file for concurrent
processes synchronization and re-read its content before updating it
// Lock the repository file for concurrent
goroutines or processes synchronization
fileLock
:=
flock
.
New
(
home
.
RepositoryFile
())
fileLock
:=
flock
.
New
(
home
.
RepositoryFile
())
lockCtx
,
cancel
:=
context
.
WithTimeout
(
context
.
Background
(),
30
*
time
.
Second
)
lockCtx
,
cancel
:=
context
.
WithTimeout
(
context
.
Background
(),
30
*
time
.
Second
)
defer
cancel
()
defer
cancel
()
...
@@ -147,6 +147,8 @@ func addRepository(name, url, username, password string, home helmpath.Home, cer
...
@@ -147,6 +147,8 @@ func addRepository(name, url, username, password string, home helmpath.Home, cer
return
err
return
err
}
}
// Re-read the repositories file before updating it as its content may have been changed
// by a concurrent execution after the first read and before being locked
f
,
err
=
repo
.
LoadRepositoriesFile
(
home
.
RepositoryFile
())
f
,
err
=
repo
.
LoadRepositoriesFile
(
home
.
RepositoryFile
())
if
err
!=
nil
{
if
err
!=
nil
{
return
err
return
err
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment