Skip to content

H
helm3
Commit 6cf4b870 authored by Joschka Tillmanns's avatar Joschka Tillmanns
Browse files
Options

don't do multiple chart reads on upgrade 

Signed-off-by: 's avatarJoschka Tillmanns <joschka@tillmanns.me>
parent 69002eeb
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 3 deletions
cmd/helm/upgrade.go
View file @ 6cf4b870
...@@ -248,7 +248,8 @@ func (u *upgradeCmd) run() error { ...@@ -248,7 +248,8 @@ func (u *upgradeCmd) run() error {
} }
// Check chart requirements to make sure all dependencies are present in /charts // Check chart requirements to make sure all dependencies are present in /charts
if ch, err := chartutil.Load(chartPath); err == nil { ch, err := chartutil.Load(chartPath)
if err == nil {
if req, err := chartutil.LoadRequirements(ch); err == nil { if req, err := chartutil.LoadRequirements(ch); err == nil {
if err := renderutil.CheckDependencies(ch, req); err != nil { if err := renderutil.CheckDependencies(ch, req); err != nil {
return err return err
...@@ -260,9 +261,9 @@ func (u *upgradeCmd) run() error { ...@@ -260,9 +261,9 @@ func (u *upgradeCmd) run() error {
return prettyError(err) return prettyError(err)
} }
resp, err := u.client.UpdateRelease( resp, err := u.client.UpdateReleaseFromChart(
u.release, u.release,
chartPath, ch,
helm.UpdateValueOverrides(rawVals), helm.UpdateValueOverrides(rawVals),
helm.UpgradeDryRun(u.dryRun), helm.UpgradeDryRun(u.dryRun),
helm.UpgradeRecreate(u.recreate), helm.UpgradeRecreate(u.recreate),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment