Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
70a9e4aa
Commit
70a9e4aa
authored
Oct 14, 2016
by
Matt Butcher
Committed by
GitHub
Oct 14, 2016
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1364 from technosophos/fix/1135-output-consistency
fix(helm): make 'helm install' output more consistent
parents
1a7373e5
70c453c4
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
12 deletions
+10
-12
helm.go
cmd/helm/helm.go
+1
-1
install.go
cmd/helm/install.go
+4
-6
status.go
cmd/helm/status.go
+5
-5
No files found.
cmd/helm/helm.go
View file @
70a9e4aa
...
...
@@ -143,7 +143,7 @@ func setupConnection(c *cobra.Command, args []string) error {
// Set up the gRPC config.
if
flagDebug
{
fmt
.
Printf
(
"S
erver
: %q
\n
"
,
tillerHost
)
fmt
.
Printf
(
"S
ERVER
: %q
\n
"
,
tillerHost
)
}
return
nil
}
...
...
cmd/helm/install.go
View file @
70a9e4aa
...
...
@@ -36,7 +36,6 @@ import (
"k8s.io/helm/cmd/helm/helmpath"
"k8s.io/helm/pkg/helm"
"k8s.io/helm/pkg/proto/hapi/release"
"k8s.io/helm/pkg/timeconv"
)
const
installDesc
=
`
...
...
@@ -143,7 +142,7 @@ func newInstallCmd(c helm.Interface, out io.Writer) *cobra.Command {
func
(
i
*
installCmd
)
run
()
error
{
if
flagDebug
{
fmt
.
Fprintf
(
i
.
out
,
"C
hart path
: %s
\n
"
,
i
.
chartPath
)
fmt
.
Fprintf
(
i
.
out
,
"C
HART PATH
: %s
\n
"
,
i
.
chartPath
)
}
rawVals
,
err
:=
i
.
vals
()
...
...
@@ -158,7 +157,7 @@ func (i *installCmd) run() error {
return
err
}
// Print the final name so the user knows what the final name of the release is.
fmt
.
Printf
(
"F
inal name
: %s
\n
"
,
i
.
name
)
fmt
.
Printf
(
"F
INAL NAME
: %s
\n
"
,
i
.
name
)
}
res
,
err
:=
i
.
client
.
InstallRelease
(
...
...
@@ -226,12 +225,11 @@ func (i *installCmd) printRelease(rel *release.Release) {
// TODO: Switch to text/template like everything else.
if
flagDebug
{
fmt
.
Fprintf
(
i
.
out
,
"NAME: %s
\n
"
,
rel
.
Name
)
fmt
.
Fprintf
(
i
.
out
,
"NAMESPACE: %s
\n
"
,
rel
.
Namespace
)
fmt
.
Fprintf
(
i
.
out
,
"INFO: %s %s
\n
"
,
timeconv
.
String
(
rel
.
Info
.
LastDeployed
),
rel
.
Info
.
Status
)
fmt
.
Fprintf
(
i
.
out
,
"TARGET NAMESPACE: %s
\n
"
,
rel
.
Namespace
)
fmt
.
Fprintf
(
i
.
out
,
"CHART: %s %s
\n
"
,
rel
.
Chart
.
Metadata
.
Name
,
rel
.
Chart
.
Metadata
.
Version
)
fmt
.
Fprintf
(
i
.
out
,
"MANIFEST: %s
\n
"
,
rel
.
Manifest
)
}
else
{
fmt
.
Fprint
ln
(
i
.
out
,
rel
.
Name
)
fmt
.
Fprint
f
(
i
.
out
,
"NAME: %s
\n
"
,
rel
.
Name
)
}
}
...
...
cmd/helm/status.go
View file @
70a9e4aa
...
...
@@ -79,18 +79,18 @@ func (s *statusCmd) run() error {
// install / upgrade
func
PrintStatus
(
out
io
.
Writer
,
res
*
services
.
GetReleaseStatusResponse
)
{
if
res
.
Info
.
LastDeployed
!=
nil
{
fmt
.
Fprintf
(
out
,
"L
ast Deployed
: %s
\n
"
,
timeconv
.
String
(
res
.
Info
.
LastDeployed
))
fmt
.
Fprintf
(
out
,
"L
AST DEPLOYED
: %s
\n
"
,
timeconv
.
String
(
res
.
Info
.
LastDeployed
))
}
fmt
.
Fprintf
(
out
,
"N
amespace
: %s
\n
"
,
res
.
Namespace
)
fmt
.
Fprintf
(
out
,
"S
tatus
: %s
\n
"
,
res
.
Info
.
Status
.
Code
)
fmt
.
Fprintf
(
out
,
"N
AMESPACE
: %s
\n
"
,
res
.
Namespace
)
fmt
.
Fprintf
(
out
,
"S
TATUS
: %s
\n
"
,
res
.
Info
.
Status
.
Code
)
if
res
.
Info
.
Status
.
Details
!=
nil
{
fmt
.
Fprintf
(
out
,
"Details: %s
\n
"
,
res
.
Info
.
Status
.
Details
)
}
fmt
.
Fprintf
(
out
,
"
\n
"
)
if
len
(
res
.
Info
.
Status
.
Resources
)
>
0
{
fmt
.
Fprintf
(
out
,
"R
esources
:
\n
%s
\n
"
,
res
.
Info
.
Status
.
Resources
)
fmt
.
Fprintf
(
out
,
"R
ESOURCES
:
\n
%s
\n
"
,
res
.
Info
.
Status
.
Resources
)
}
if
len
(
res
.
Info
.
Status
.
Notes
)
>
0
{
fmt
.
Fprintf
(
out
,
"N
otes
:
\n
%s
\n
"
,
res
.
Info
.
Status
.
Notes
)
fmt
.
Fprintf
(
out
,
"N
OTES
:
\n
%s
\n
"
,
res
.
Info
.
Status
.
Notes
)
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment