Skip to content

H
helm3
Commit 880d3a8e authored by vaikas-google's avatar vaikas-google
Browse files
Options

Address code review comments

parent b6cccb45
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 0 deletions
client/registry/github_registry.go
View file @ 880d3a8e
...@@ -27,6 +27,7 @@ type GithubRegistry struct { ...@@ -27,6 +27,7 @@ type GithubRegistry struct {
client *github.Client client *github.Client
} }
// NewGithubRegistry creates a Registry that can be used to talk to github.
func NewGithubRegistry(owner string, repository string) *GithubRegistry { func NewGithubRegistry(owner string, repository string) *GithubRegistry {
return &GithubRegistry{ return &GithubRegistry{
owner: owner, owner: owner,
...@@ -35,6 +36,7 @@ func NewGithubRegistry(owner string, repository string) *GithubRegistry { ...@@ -35,6 +36,7 @@ func NewGithubRegistry(owner string, repository string) *GithubRegistry {
} }
} }
// List the types from the Registry.
func (g *GithubRegistry) List() ([]Type, error) { func (g *GithubRegistry) List() ([]Type, error) {
// First list all the types at the top level. // First list all the types at the top level.
types, err := g.getDirs(TypesDir) types, err := g.getDirs(TypesDir)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment