Commit 973ed170 authored by Matt Butcher's avatar Matt Butcher

fix(helm): add line feed between --values and --set data

Currently, --set simply appends data to the end of the existing values
YAML data. If a values file does not have a line feed at the end, the
set data is mis-appended. This fixes the issue by inserting a linefeed
between the --values data and --set data.

Closes #1430
parent 2eed3f04
......@@ -207,6 +207,10 @@ func (i *installCmd) vals() ([]byte, error) {
return []byte{}, err
}
buffer.Write(bytes)
// Force a new line. An extra won't matter, but a missing one can
// break things. https://github.com/kubernetes/helm/issues/1430
buffer.WriteRune('\n')
}
// User specified value pairs via --set
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment