Unverified Commit af0bb6d2 authored by Matthew Fisher's avatar Matthew Fisher Committed by GitHub

Merge pull request #5760 from mortent/revertValidationFix

fix(helm): Disable schema validation for manifests
parents ed237362 ad886c5e
...@@ -157,13 +157,16 @@ func (c *Client) BuildUnstructured(namespace string, reader io.Reader) (Result, ...@@ -157,13 +157,16 @@ func (c *Client) BuildUnstructured(namespace string, reader io.Reader) (Result,
} }
// Validate reads Kubernetes manifests and validates the content. // Validate reads Kubernetes manifests and validates the content.
//
// This function does not actually do schema validation of manifests. Adding
// validation now breaks existing clients of helm: https://github.com/helm/helm/issues/5750
func (c *Client) Validate(namespace string, reader io.Reader) error { func (c *Client) Validate(namespace string, reader io.Reader) error {
_, err := c.NewBuilder(). _, err := c.NewBuilder().
Unstructured(). Unstructured().
ContinueOnError(). ContinueOnError().
NamespaceParam(namespace). NamespaceParam(namespace).
DefaultNamespace(). DefaultNamespace().
Schema(c.validator()). // Schema(c.validator()). // No schema validation
Stream(reader, ""). Stream(reader, "").
Flatten(). Flatten().
Do().Infos() Do().Infos()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment