Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
d59f66fc
Commit
d59f66fc
authored
Nov 12, 2016
by
Adam Reese
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(*): fix new linter errors
parent
79e43a75
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
14 additions
and
2 deletions
+14
-2
dependency_update_test.go
cmd/helm/dependency_update_test.go
+3
-0
repo_remove_test.go
cmd/helm/repo_remove_test.go
+3
-0
expand.go
pkg/chartutil/expand.go
+1
-1
tunnel.go
pkg/kube/tunnel.go
+3
-0
template.go
pkg/lint/rules/template.go
+3
-0
server.go
pkg/repo/repotest/server.go
+1
-1
No files found.
cmd/helm/dependency_update_test.go
View file @
d59f66fc
...
@@ -49,6 +49,9 @@ func TestDependencyUpdateCmd(t *testing.T) {
...
@@ -49,6 +49,9 @@ func TestDependencyUpdateCmd(t *testing.T) {
srv
:=
repotest
.
NewServer
(
hh
)
srv
:=
repotest
.
NewServer
(
hh
)
defer
srv
.
Stop
()
defer
srv
.
Stop
()
copied
,
err
:=
srv
.
CopyCharts
(
"testdata/testcharts/*.tgz"
)
copied
,
err
:=
srv
.
CopyCharts
(
"testdata/testcharts/*.tgz"
)
if
err
!=
nil
{
t
.
Fatal
(
err
)
}
t
.
Logf
(
"Copied charts:
\n
%s"
,
strings
.
Join
(
copied
,
"
\n
"
))
t
.
Logf
(
"Copied charts:
\n
%s"
,
strings
.
Join
(
copied
,
"
\n
"
))
t
.
Logf
(
"Listening on directory %s"
,
srv
.
Root
())
t
.
Logf
(
"Listening on directory %s"
,
srv
.
Root
())
...
...
cmd/helm/repo_remove_test.go
View file @
d59f66fc
...
@@ -32,6 +32,9 @@ func TestRepoRemove(t *testing.T) {
...
@@ -32,6 +32,9 @@ func TestRepoRemove(t *testing.T) {
b
:=
bytes
.
NewBuffer
(
nil
)
b
:=
bytes
.
NewBuffer
(
nil
)
home
,
err
:=
tempHelmHome
(
t
)
home
,
err
:=
tempHelmHome
(
t
)
if
err
!=
nil
{
t
.
Fatal
(
err
)
}
defer
os
.
Remove
(
home
)
defer
os
.
Remove
(
home
)
hh
:=
helmpath
.
Home
(
home
)
hh
:=
helmpath
.
Home
(
home
)
...
...
pkg/chartutil/expand.go
View file @
d59f66fc
...
@@ -72,7 +72,7 @@ func Expand(dir string, r io.Reader) error {
...
@@ -72,7 +72,7 @@ func Expand(dir string, r io.Reader) error {
return
nil
return
nil
}
}
// ExpandFile expands the src file into the dest direct
ro
y.
// ExpandFile expands the src file into the dest direct
or
y.
func
ExpandFile
(
dest
,
src
string
)
error
{
func
ExpandFile
(
dest
,
src
string
)
error
{
h
,
err
:=
os
.
Open
(
src
)
h
,
err
:=
os
.
Open
(
src
)
if
err
!=
nil
{
if
err
!=
nil
{
...
...
pkg/kube/tunnel.go
View file @
d59f66fc
...
@@ -110,6 +110,9 @@ func getAvailablePort() (int, error) {
...
@@ -110,6 +110,9 @@ func getAvailablePort() (int, error) {
defer
l
.
Close
()
defer
l
.
Close
()
_
,
p
,
err
:=
net
.
SplitHostPort
(
l
.
Addr
()
.
String
())
_
,
p
,
err
:=
net
.
SplitHostPort
(
l
.
Addr
()
.
String
())
if
err
!=
nil
{
return
0
,
err
}
port
,
err
:=
strconv
.
Atoi
(
p
)
port
,
err
:=
strconv
.
Atoi
(
p
)
if
err
!=
nil
{
if
err
!=
nil
{
return
0
,
err
return
0
,
err
...
...
pkg/lint/rules/template.go
View file @
d59f66fc
...
@@ -138,6 +138,9 @@ func validateNoMissingValues(templatesPath string, chartValues chartutil.Values,
...
@@ -138,6 +138,9 @@ func validateNoMissingValues(templatesPath string, chartValues chartutil.Values,
tmpl
:=
template
.
New
(
"tpl"
)
.
Funcs
(
engine
.
FuncMap
())
tmpl
:=
template
.
New
(
"tpl"
)
.
Funcs
(
engine
.
FuncMap
())
// If the templatesPath includes any *.tpl files we will parse and import them as associated templates
// If the templatesPath includes any *.tpl files we will parse and import them as associated templates
associatedTemplates
,
err
:=
filepath
.
Glob
(
filepath
.
Join
(
templatesPath
,
"*.tpl"
))
associatedTemplates
,
err
:=
filepath
.
Glob
(
filepath
.
Join
(
templatesPath
,
"*.tpl"
))
if
err
!=
nil
{
return
err
}
if
len
(
associatedTemplates
)
>
0
{
if
len
(
associatedTemplates
)
>
0
{
tmpl
,
err
=
tmpl
.
ParseFiles
(
associatedTemplates
...
)
tmpl
,
err
=
tmpl
.
ParseFiles
(
associatedTemplates
...
)
...
...
pkg/repo/repotest/server.go
View file @
d59f66fc
...
@@ -75,7 +75,7 @@ func NewServer(docroot string) *Server {
...
@@ -75,7 +75,7 @@ func NewServer(docroot string) *Server {
return
srv
return
srv
}
}
// Server is an implementa
it
on of a repository server for testing.
// Server is an implementa
ti
on of a repository server for testing.
type
Server
struct
{
type
Server
struct
{
docroot
string
docroot
string
srv
*
httptest
.
Server
srv
*
httptest
.
Server
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment