Commit e028be06 authored by Steven E. Harris's avatar Steven E. Harris Committed by GitHub

Merge pull request #2650 from arschles/apiservice

Add the "APIService" kind to the installation sort order
parents 72bb046c 58a2d7b5
...@@ -49,12 +49,14 @@ var InstallOrder SortOrder = []string{ ...@@ -49,12 +49,14 @@ var InstallOrder SortOrder = []string{
"Job", "Job",
"CronJob", "CronJob",
"Ingress", "Ingress",
"APIService",
} }
// UninstallOrder is the order in which manifests should be uninstalled (by Kind). // UninstallOrder is the order in which manifests should be uninstalled (by Kind).
// //
// Those occurring earlier in the list get uninstalled before those occurring later in the list. // Those occurring earlier in the list get uninstalled before those occurring later in the list.
var UninstallOrder SortOrder = []string{ var UninstallOrder SortOrder = []string{
"APIService",
"Ingress", "Ingress",
"Service", "Service",
"CronJob", "CronJob",
......
...@@ -140,6 +140,11 @@ func TestKindSorter(t *testing.T) { ...@@ -140,6 +140,11 @@ func TestKindSorter(t *testing.T) {
content: "", content: "",
head: &util.SimpleHead{Kind: "StatefulSet"}, head: &util.SimpleHead{Kind: "StatefulSet"},
}, },
{
name: "w",
content: "",
head: &util.SimpleHead{Kind: "APIService"},
},
} }
for _, test := range []struct { for _, test := range []struct {
...@@ -147,8 +152,8 @@ func TestKindSorter(t *testing.T) { ...@@ -147,8 +152,8 @@ func TestKindSorter(t *testing.T) {
order SortOrder order SortOrder
expected string expected string
}{ }{
{"install", InstallOrder, "abcdefghijklmnopqrstuv!"}, {"install", InstallOrder, "abcdefghijklmnopqrstuvw!"},
{"uninstall", UninstallOrder, "vmutsrqponlkjihgfedcba!"}, {"uninstall", UninstallOrder, "wvmutsrqponlkjihgfedcba!"},
} { } {
var buf bytes.Buffer var buf bytes.Buffer
t.Run(test.description, func(t *testing.T) { t.Run(test.description, func(t *testing.T) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment