Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
e028be06
Commit
e028be06
authored
Jul 10, 2017
by
Steven E. Harris
Committed by
GitHub
Jul 10, 2017
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2650 from arschles/apiservice
Add the "APIService" kind to the installation sort order
parents
72bb046c
58a2d7b5
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
2 deletions
+9
-2
kind_sorter.go
pkg/tiller/kind_sorter.go
+2
-0
kind_sorter_test.go
pkg/tiller/kind_sorter_test.go
+7
-2
No files found.
pkg/tiller/kind_sorter.go
View file @
e028be06
...
@@ -49,12 +49,14 @@ var InstallOrder SortOrder = []string{
...
@@ -49,12 +49,14 @@ var InstallOrder SortOrder = []string{
"Job"
,
"Job"
,
"CronJob"
,
"CronJob"
,
"Ingress"
,
"Ingress"
,
"APIService"
,
}
}
// UninstallOrder is the order in which manifests should be uninstalled (by Kind).
// UninstallOrder is the order in which manifests should be uninstalled (by Kind).
//
//
// Those occurring earlier in the list get uninstalled before those occurring later in the list.
// Those occurring earlier in the list get uninstalled before those occurring later in the list.
var
UninstallOrder
SortOrder
=
[]
string
{
var
UninstallOrder
SortOrder
=
[]
string
{
"APIService"
,
"Ingress"
,
"Ingress"
,
"Service"
,
"Service"
,
"CronJob"
,
"CronJob"
,
...
...
pkg/tiller/kind_sorter_test.go
View file @
e028be06
...
@@ -140,6 +140,11 @@ func TestKindSorter(t *testing.T) {
...
@@ -140,6 +140,11 @@ func TestKindSorter(t *testing.T) {
content
:
""
,
content
:
""
,
head
:
&
util
.
SimpleHead
{
Kind
:
"StatefulSet"
},
head
:
&
util
.
SimpleHead
{
Kind
:
"StatefulSet"
},
},
},
{
name
:
"w"
,
content
:
""
,
head
:
&
util
.
SimpleHead
{
Kind
:
"APIService"
},
},
}
}
for
_
,
test
:=
range
[]
struct
{
for
_
,
test
:=
range
[]
struct
{
...
@@ -147,8 +152,8 @@ func TestKindSorter(t *testing.T) {
...
@@ -147,8 +152,8 @@ func TestKindSorter(t *testing.T) {
order
SortOrder
order
SortOrder
expected
string
expected
string
}{
}{
{
"install"
,
InstallOrder
,
"abcdefghijklmnopqrstuv!"
},
{
"install"
,
InstallOrder
,
"abcdefghijklmnopqrstuv
w
!"
},
{
"uninstall"
,
UninstallOrder
,
"vmutsrqponlkjihgfedcba!"
},
{
"uninstall"
,
UninstallOrder
,
"
w
vmutsrqponlkjihgfedcba!"
},
}
{
}
{
var
buf
bytes
.
Buffer
var
buf
bytes
.
Buffer
t
.
Run
(
test
.
description
,
func
(
t
*
testing
.
T
)
{
t
.
Run
(
test
.
description
,
func
(
t
*
testing
.
T
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment