Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* fix(helm): fix regression with TLS flags/envvars

This change fixes some of the assumptions made in an earlier commit. Helm's TLS flags and environment variables were not respected because they were parsed well before execution (during settings.AddFlagsTLS()), causing erroneous behaviour at runtime. By re-introducing environment.Init(), Helm can properly parse environment variables at the correct time.

One change that had to occur in this PR is the fact that we need to call settings.Init() each time we call settings.AddFlagsTLS(). This is because each command owns its own FlagSet, so we need to parse each flagset to read and propagate the environment variables correctly.

I also noticed that we were maintaining two separate variables for each TLS value. Refactoring out some of the older code to all use the settings object makes the code much cleaner to read and fixes an issue where setting a flag or environment variable would propagate to the settings object, but we'd be reading from tlsEnable.

I've also added some unit tests to ensure this regression doesn't occur again.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* fix bug where os.ExpandEnv() on the default value causes differing behaviour
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* add more context to the TODO/FIXME messages
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

Fixes Issue #4299 and Issue #4445
Signed-off-by: Caleb Delnay <calebdelnay@gmail.com>

changed instancelease to instance in service template

closes #4661
Signed-off-by: Qiang Li <liqiang@gmail.com>

* Install tiller as well if it exists
Signed-off-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>

* Fix message

ref: https://github.com/helm/helm/pull/4648#discussion_r218229227Signed-off-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>

Signed-off-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>

Signed-off-by: Louis Munro <lm@louismunro.com>

Should fix #4585.
Signed-off-by: Steve Wolter <swolter@google.com>

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

Signed-off-by: cpanato <ctadeu@gmail.com>

linters were failing with: pkg/urlutil/urlutil_test.go:1::warning: file is not gofmted with -s (gofmt)
Signed-off-by: Helgi Þorbjörnsson <helgith@gmail.com>

Clearer wording when using pipelines

Signed-off-by: Nenad Stojanovikj <nekk1@live.com>

Fix typo
Signed-off-by: Pratyush Verma <vermapratyush@gmail.com>

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* Fix race in helm list when partitioning

Problem:
The chunks slice that is passed through the channel is reused for each
partition. This means that encoding the release into a message is racing with
populating the next partition, causing the results to sometimes not fit in the
message, and the release list to be incorrect

Solution:
Allocate a new slice for each partition

Issue #3322
Signed-off-by: Brian Marshall <bmarshall13@users.noreply.github.com>
(cherry picked from commit a0858e29d877b8aa19478133865e45958ff21a9e)

* fix import sorting
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* ref(release_server_test): use NewReleaseServer()
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* add unit test for race condition in `helm list`
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* fix(helm): Use env to locate bash

Leverage '/usr/bin/env bash` for find bash instead of hardcoding
'/bin/bash' since some *nix OSes have it installed elsewhere.
Signed-off-by: Robert James Hernandez <rob@sarcasticadmin.com>

* test(helm): Adding case for versions short flag

When git sha is empty if being built from tarball running 'helm version
--short' should just ignore '--short' since sha is empty. Adding test
to ensure this is the case.
Signed-off-by: Robert James Hernandez <rob@sarcasticadmin.com>

* fix(helm): ignore short flag when sha is empty
Signed-off-by: Robert James Hernandez <rob@sarcasticadmin.com>

Signed-off-by: tgarlot <thomas@garlot.net>

Signed-off-by: Anton Osmond <antonosmond@gmail.com>

Signed-off-by: Ian Chen <ianchen06@gmail.com>

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* Avoid importing k8s.io/kubernetes from pkg/helm

When writing a helm client (e.g. a helm plugin) that talks to tiller importing k8s.io/helm/pkg/helm to get the grpc client is key.
This pkg should not have a dependency to the k8s.io/kubernetes to avoid pulling in a lot of code that is only used within tiller and blow up binary sizes.
Signed-off-by: Fabian Ruff <fabian@progra.de>

* Add references to pull request in errors message
Signed-off-by: Fabian Ruff <fabian@progra.de>

* copy helper function from pkg/storage/driver
Signed-off-by: Fabian Ruff <fabian@progra.de>

* Move storage errors to seperate package
Signed-off-by: Fabian Ruff <fabian@progra.de>

* Keep old  error variables for backward compatibility
Signed-off-by: Fabian Ruff <fabian@progra.de>

Signed-off-by: Christian Koeberl <christian.koeberl@gmail.com>

New helm notes command to display notes provided by a release's chart

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

feat(helm): add ability to sort release list by chart name

Fix init wait on tls

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

This will fix the bug where 'helm init --wait' fails when TLS is used.
Signed-off-by: aswinkarthik <aswinkarthik93@gmail.com>

Do not fail linting because of missing 'required' template values

Flesh out the fake client even more

Add containerized options for tests in Makefile

Moving from CLA to DCO in contribution guide

feat(helm): hiding password input on terminal

When using "helm repo add" with "--username" and without "--password",
hide user's input with a password prompt. This allows users to not
expose their passwords to the command line history.

Add an option to run the `test-unit`, `test-style`, and `test`
steps from the `Makefile` insides of a docker container. Doing so
isolates this component of helm development from any other aspect of
your global go environment.

These commands all have the name `docker-*`. Long term, there may
be reproducibility benefits to running all of the Make steps in a
container by default, in which case `containerized-test-unit` could
become `test-unit`.

Improve documentation for helm upgrade (#4030)