Signed-off-by: Louis-Etienne Dorval <ledor473@hotmail.com>

* Update Contributing.md to remove mention of CLA
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>

* Add hyperlink to git page in CONTRIBUTING.md
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>

Signed-off-by: Alpha <jhexe2002@gmail.com>

Update of the client-go package changed the status output to only include
the age of resources. The new printer in client-go only formats the output
to include details of specific resources if the internal representation
of resources are passed into the printer. This PR updates helm to convert
resources to the internal type before printing.

Closes #4712
Signed-off-by: Morten Torkildsen <mortent@google.com>

Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>

Signed-off-by: Mischa Gresser <mgresser@dstillery.com>

* Add test template example for helm create

As helm create ganerates an nginx chart, the example is based on
https://github.com/helm/helm/blob/master/docs/examples/nginx/templates/
service-test.yaml
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

* Update after review

- https://github.com/helm/helm/pull/4524#pullrequestreview-155183390
- https://github.com/helm/helm/pull/4524#pullrequestreview-155379922
- Fix where app.kubernetes.io/instance was incorrect in service selector
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

* Add doc update
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

* Update GO formatting
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

* feat(helm): add $HELM_KEY_PASSPHRASE environment variable for signing helm charts

If $HELM_KEY_PASSPHRASE is set then helm package sign command will not prompt the
user to enter the passphrase for the private key
Signed-off-by: Anumita Shenoy <ansheno@microsoft.com>

* docs(helm):  added documentation for HELM_KEY_PASSPHRASE

Added description for HELM_KEY_PASSPHRASE
Signed-off-by: Anumita Shenoy <ansheno@microsoft.com>

Signed-off-by: Etienne Tremel <etienne.tremel@container-solutions.com>

Signed-off-by: Thomas Yuan <thomas@cppcoder.net>

Signed-off-by: Matt Tucker <ultimateboy@gmail.com>

fix paths in the ingress template and values file written by helm create

Add the `.vscode` folder to the `.helmignore` file

Remove redundant nil checks

ref(*): kubernetes v1.12 support

Signed-off-by: Rijnard van Tonder <hi.teresy@gmail.com>

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

Signed-off-by: Florian Rusch <git@florianrusch.de>

Signed-off-by: Adam Reese <adam@reese.io>

Use 'apps/v1' as the apiVersion field for the deployment.yaml written
by the 'helm create' command, rather than the deprecated 'apps/v1beta2'.
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

Signed-off-by: Colin Panisset <colin.panisset@cevo.com.au>

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* fix(helm): fix regression with TLS flags/envvars

This change fixes some of the assumptions made in an earlier commit. Helm's TLS flags and environment variables were not respected because they were parsed well before execution (during settings.AddFlagsTLS()), causing erroneous behaviour at runtime. By re-introducing environment.Init(), Helm can properly parse environment variables at the correct time.

One change that had to occur in this PR is the fact that we need to call settings.Init() each time we call settings.AddFlagsTLS(). This is because each command owns its own FlagSet, so we need to parse each flagset to read and propagate the environment variables correctly.

I also noticed that we were maintaining two separate variables for each TLS value. Refactoring out some of the older code to all use the settings object makes the code much cleaner to read and fixes an issue where setting a flag or environment variable would propagate to the settings object, but we'd be reading from tlsEnable.

I've also added some unit tests to ensure this regression doesn't occur again.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* fix bug where os.ExpandEnv() on the default value causes differing behaviour
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* add more context to the TODO/FIXME messages
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

Fixes Issue #4299 and Issue #4445
Signed-off-by: Caleb Delnay <calebdelnay@gmail.com>

changed instancelease to instance in service template

closes #4661
Signed-off-by: Qiang Li <liqiang@gmail.com>

* Install tiller as well if it exists
Signed-off-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>

* Fix message

ref: https://github.com/helm/helm/pull/4648#discussion_r218229227Signed-off-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>

Signed-off-by: Yuya Takeyama <sign.of.the.wolf.pentagram@gmail.com>

Signed-off-by: Louis Munro <lm@louismunro.com>

Should fix #4585.
Signed-off-by: Steve Wolter <swolter@google.com>

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

Signed-off-by: cpanato <ctadeu@gmail.com>

linters were failing with: pkg/urlutil/urlutil_test.go:1::warning: file is not gofmted with -s (gofmt)
Signed-off-by: Helgi Þorbjörnsson <helgith@gmail.com>

Clearer wording when using pipelines

Signed-off-by: Nenad Stojanovikj <nekk1@live.com>

Fix typo
Signed-off-by: Pratyush Verma <vermapratyush@gmail.com>

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

* Fix race in helm list when partitioning

Problem:
The chunks slice that is passed through the channel is reused for each
partition. This means that encoding the release into a message is racing with
populating the next partition, causing the results to sometimes not fit in the
message, and the release list to be incorrect

Solution:
Allocate a new slice for each partition

Issue #3322
Signed-off-by: Brian Marshall <bmarshall13@users.noreply.github.com>
(cherry picked from commit a0858e29d877b8aa19478133865e45958ff21a9e)

* fix import sorting
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* ref(release_server_test): use NewReleaseServer()
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* add unit test for race condition in `helm list`
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

* fix(helm): Use env to locate bash

Leverage '/usr/bin/env bash` for find bash instead of hardcoding
'/bin/bash' since some *nix OSes have it installed elsewhere.
Signed-off-by: Robert James Hernandez <rob@sarcasticadmin.com>

* test(helm): Adding case for versions short flag

When git sha is empty if being built from tarball running 'helm version
--short' should just ignore '--short' since sha is empty. Adding test
to ensure this is the case.
Signed-off-by: Robert James Hernandez <rob@sarcasticadmin.com>

* fix(helm): ignore short flag when sha is empty
Signed-off-by: Robert James Hernandez <rob@sarcasticadmin.com>