Skip to content

H
helm3
Switch branch/tag
  1. 11 Jul, 2019 1 commit
    • Oleg Sidorov's avatar
      chartutil.ReadValues is forced to unmarshal numbers into json.Number · 9014bd9c
      Oleg Sidorov authored 
      This change is an attempt to address the common problem of json number
unmarshalling where any number is converted into a float64 and
represented in a scientific notation on a marshall call. This behavior
breaks things like: chart versions and image tags if not converted to
yaml strings explicitly.

An example of this behavior: k8s failure to fetch an image tagged with a
big number like: $IMAGE:20190612073634 after a few steps of yaml
re-rendering turns into: $IMAGE:2.0190612073634e+13.

Example issue: https://github.com/helm/helm/issues/1707

This commit forces yaml parser to use JSON modifiers and explicitly
enables interface{} unmarshalling instead of float64. The change
introduced might be breaking so should be processed with an extra care.

Due to the fact helm mostly dals with human-produced data (charts), we
have a decent level of confidence this change looses no functionality
helm users rely upon (the scientific notation).

Relevant doc: https://golang.org/pkg/encoding/json/#Decoder.UseNumberSigned-off-by: 's avatarOleg Sidorov <oleg.sidorov@booking.com>
      9014bd9c
  3. 08 Jul, 2019 1 commit
  5. 03 Jul, 2019 6 commits
  7. 26 Jun, 2019 4 commits
  9. 24 Jun, 2019 4 commits
  11. 23 Jun, 2019 1 commit
  13. 22 Jun, 2019 1 commit
  15. 21 Jun, 2019 1 commit
  17. 20 Jun, 2019 1 commit
  19. 18 Jun, 2019 3 commits
  21. 17 Jun, 2019 6 commits
  23. 14 Jun, 2019 1 commit
  25. 13 Jun, 2019 3 commits
  27. 12 Jun, 2019 4 commits
  29. 10 Jun, 2019 3 commits