1. 13 May, 2016 1 commit
    • Carl Mastrangelo's avatar
      http2/hpack: forbid excess and invalid padding in hpack decoder · 6050c111
      Carl Mastrangelo authored
      This change fixes a few bugs in the HPACK decoder:
       * Excess trailing padding is treated as an error per the HPACK Spec
           section 5.2
       * Non EOS prefix padding is treated as an error
       * Max length is now enforced for all decoded symbols
      
      The idea here is to keep track of the decoded symbol length, rather
      than the number of unconsumed bits in cur.  To this end, nbits has
      been renamed cbits (cur bits), and sbits (sym bits) has been
      introduced.  The main problem with using nbits is that it can easily
      be zero, such as when decoding {0xff, 0xff}.  Using a clear moniker
      makes it easier to see why checking cbits > 0 at the end of the
      function is incorrect.
      
      Fixes golang/go#15614
      
      Change-Id: I1ae868caa9c207fcf9c9dec7f10ee9f400211f99
      Reviewed-on: https://go-review.googlesource.com/23067Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      6050c111
  2. 10 May, 2016 1 commit
  3. 06 May, 2016 1 commit
  4. 05 May, 2016 2 commits
  5. 01 May, 2016 1 commit
  6. 27 Apr, 2016 1 commit
  7. 26 Apr, 2016 1 commit
  8. 22 Apr, 2016 1 commit
  9. 21 Apr, 2016 1 commit
  10. 12 Apr, 2016 2 commits
  11. 11 Apr, 2016 5 commits
  12. 07 Apr, 2016 5 commits
  13. 06 Apr, 2016 1 commit
  14. 05 Apr, 2016 2 commits
  15. 03 Apr, 2016 1 commit
  16. 31 Mar, 2016 3 commits
  17. 28 Mar, 2016 5 commits
  18. 25 Mar, 2016 1 commit
  19. 24 Mar, 2016 1 commit
  20. 22 Mar, 2016 2 commits
  21. 21 Mar, 2016 1 commit
  22. 20 Mar, 2016 1 commit