Commits · 7ed368b9e76faff84e1dbbe6ae120903e5377c24 · go / net

25 Dec, 2014 1 commit

icmp: make Marshal of MessageBody, ParseMessage work correctly on parameter problem message · 7ed368b9

Mikio Hara authored Dec 25, 2014

The wire format of parameter problem message is slightly different
between ICMPv4 and ICMPv6. We need to distinguish each message's
protocol family for avoiding dropping wrong wire format stuff on the
wire.

This is an API breaking change.

type MessageBody interface, Marshal() ([]byte, error)

is replaced with

type MessageBody interface, Marshal(int) ([]byte, error)

Fixes #9394.

Change-Id: Id692c76f85a2714dd011342e648b31395ca668bf

7ed368b9

24 Dec, 2014 1 commit

ipv4: clarify each platform's behavior on marshaling, parsing ipv4 header · b1ee7b3f

Mikio Hara authored Dec 24, 2014

For now we see three types of behaviors: conventional BSD, FreeBSD and
other that including Linux, OpenBSD, Solaris and Windows.

Change-Id: Iff7efe50b40bd3537b6ed8f02245552d8216c4f3

b1ee7b3f

23 Dec, 2014 1 commit
- net: add .gitattributes (fixes windows build) · 8c5df243
  Alex Brainman authored Dec 23, 2014
```
Fixes #9281

Change-Id: I144afc9736d3d0ba1cdd2693efd0c7f07b1b8bf3
```
  8c5df243
10 Dec, 2014 1 commit
- internal/iana: fix a import comment in code generator. · cbcac7bb
  David Symonds authored Dec 10, 2014
```
Change-Id: I09adabf07366426451303f72b0f2e6a0869b7508
```
  cbcac7bb
09 Dec, 2014 1 commit
- net: add import comments. · 8aa6e209
  David Symonds authored Dec 09, 2014
```
Change-Id: Ifab0fdaec1d810d268b7c19ad30f476802203b37
```
  8aa6e209
07 Dec, 2014 2 commits
- remove codereview.cfg. · ccfcd82c
  David Symonds authored Dec 07, 2014
  
  ccfcd82c
- convert .hgignore to .gitignore. · a63ec842
  David Symonds authored Dec 07, 2014
  
  a63ec842
05 Dec, 2014 1 commit

x/net/icmp: make use of strconv · 2e20f339

Mikio Hara authored Dec 05, 2014

There is no circular dependencies, no need to hesitate to use it.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/185900043

2e20f339

04 Dec, 2014 3 commits

x/net/ipv6: split Set method of ICMPFilter into Accept, Block methods · 668aea8e

Mikio Hara authored Dec 04, 2014

This is an API breaking change.

method (*ICMPFilter) Set(ICMPType, bool)

is now replaced with

method (*ICMPFilter) Accept(ICMPType)
method (*ICMPFilter) Block(ICMPType)

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182450043

668aea8e

x/net/ipv4: add support for icmp filter on linux · e92559f3
Mikio Hara authored Dec 04, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/179510043
```
e92559f3

x/net/icmp: update package documentation · 0d0e5840

Mikio Hara authored Dec 04, 2014

Also fixes typos.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182410043

0d0e5840

03 Dec, 2014 6 commits

x/net/ipv6: use new import path for icmp · 597bbe19
Mikio Hara authored Dec 03, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/183040043
```
597bbe19
x/net/ipv4: use new import path for icmp · e50142f8
Mikio Hara authored Dec 03, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/183030043
```
e50142f8

x/net/icmp: new package · b745b482

Mikio Hara authored Dec 03, 2014

This CL makes icmp an external package.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182370043

b745b482

x/net/internal/icmp: add support for non-privileged ICMP endpoint, known as ping socket · fc168c3c

Mikio Hara authored Dec 03, 2014

This CL adds PacketConn struct that implements net.PacketConn
interface.

Update golang/go#9166

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182110043

fc168c3c

x/net/internal/icmp: add ParseIPv4Header · 2a8857c3

Mikio Hara authored Dec 03, 2014

This CL adds ParseIPv4Header for parsing an IPv4 header in ICMP
error message. We cannot use ipv4.ParseHeader for it because they
are different things processed by either ip_input or icmp_input.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/184850043

2a8857c3

x/net/internal/icmp: add support for error message · a21e453f

Mikio Hara authored Dec 03, 2014

This CL introduces few ICMP error message body types such as
DstUnreach, PacketTooBig, TimeExceeded or ParamProb.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/183850043

a21e453f

02 Dec, 2014 2 commits

x/net/ipv4: add icmp filter type, constant for linux · 119dea2c
Mikio Hara authored Dec 02, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182950043
```
119dea2c

x/net/ipv4: enable IP_STRIPHDR by default on darwin · c220db41

Mikio Hara authored Dec 02, 2014

According to github.com/opensource-apple/xnu.git, IP_STRIPHDR sticky
socket option was introduced in xnu-517 (Darwin 7.0, OS X 10.3).

LGTM=iant
R=iant, gobot
CC=golang-codereviews
https://golang.org/cl/176480043

c220db41

29 Nov, 2014 3 commits

x/net/ipv4: enable IP_STRIPHDR sticky socket option on latest darwin kernels · 5c9495a3

Mikio Hara authored Nov 29, 2014

This reduces allocation and copy ops with net.IPConn-based
ipv4.PacketConn on latest darwin kernels.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/184770043

5c9495a3

x/net/ipv6: add Header, ParseHeader · d8675581

Mikio Hara authored Nov 29, 2014

This CL adds Header type and ParseHeader function for convenience
in parsing ICMP error messages such as destination unreachable,
packet too big, time exceeded and parameter problem.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/177530043

d8675581

x/net/{internal/icmp,ipv4,ipv6}: better method for icmp.Type interface · e93b1edd
Mikio Hara authored Nov 29, 2014
```
LGTM=iant
R=iant, bradfitz
CC=golang-codereviews
https://golang.org/cl/173670044
```
e93b1edd

26 Nov, 2014 2 commits
- x/net/ipv6: remove unnecessary stubs · 3748d8c2
  Mikio Hara authored Nov 26, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/183750044
```
  3748d8c2
- x/net/ipv4: remove unnecessary stubs · 41bf2334
  Mikio Hara authored Nov 26, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/181200043
```
  41bf2334
22 Nov, 2014 3 commits
- x/net/ipv6: update package documentation · d96e6bbf
  Mikio Hara authored Nov 22, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/177840043
```
  d96e6bbf
- x/net/ipv4: update package documentation · 3809e749
  Mikio Hara authored Nov 22, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/173300043
```
  3809e749
- x/net/ipv6: fix using wrong constant in test · ed45f193
  Mikio Hara authored Nov 22, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/174480043
```
  ed45f193
19 Nov, 2014 1 commit
- x/net/ipv6: replace a magic number with an iana constant · 9f8bef6b
  Mikio Hara authored Nov 19, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/179930043
```
  9f8bef6b
18 Nov, 2014 4 commits
- x/net/ipv6: add package example · 7ad508c2
  Mikio Hara authored Nov 18, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/176960043
```
  7ad508c2
- x/net/ipv4: update package example · 7339ca67
  Mikio Hara authored Nov 18, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/178800043
```
  7339ca67
- x/net/ipv6: enable IPV6_PATHMTU ancillary data option for Linux · fb6231e1
  Mikio Hara authored Nov 18, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/176980043
```
  fb6231e1
- x/net/ipv6: enable IPV6_NEXTHOP, IPV6_PATHMTU ancillary data options for BSD variants · 88697592
  Mikio Hara authored Nov 18, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/174310043
```
  88697592
17 Nov, 2014 3 commits

x/net/ipv6: fix a nit found by vet · 5b76c804

Mikio Hara authored Nov 17, 2014

LGTM=dsymonds
R=iant, dsymonds
CC=golang-codereviews
https://golang.org/cl/176920043

5b76c804

x/net/html/charset: add missing copyright · ccf541d8

Mikio Hara authored Nov 17, 2014

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/174240043

ccf541d8

x/net/html/charset: fix nacl build · 716c3ccf

Mikio Hara authored Nov 17, 2014

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/177880043

716c3ccf

16 Nov, 2014 3 commits

x.net/ipv6: fix path mtu test on older darwin kernels · dd7a4b48
Mikio Hara authored Nov 16, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/173290043
```
dd7a4b48

x/net/ipv6: fix full stack test cases · b56b6099

Mikio Hara authored Nov 16, 2014

Readjusts Traffic Class and ICMP test cases on older darwin kernels,
per-interface link-local address multicasting and loopback interface
required test cases on BSD variants.
Also simplifies error logs.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/177790043

b56b6099

x/net/ipv4: fix full stack test cases · c25a4f30

Mikio Hara authored Nov 16, 2014

Readjusts ICMP test cases on older darwin kernels
Also simplifies error logs.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/178740043

c25a4f30

15 Nov, 2014 2 commits

x/net/ipv6: fix build on older darwin kernels · 2a8eb911

Mikio Hara authored Nov 15, 2014

A few adjustments for test cases will come in a following CL.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/176830043

2a8eb911

x/net/ipv4: fix build on older darwin kernels · 724ab9af

Mikio Hara authored Nov 15, 2014

A few adjustments for test cases will come in a following CL.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/179760044

724ab9af