- 20 Feb, 2015 1 commit
-
-
Aaron Jacobs authored
This is necessary for cleanup of any goroutine that blocks on ctx.Done(), as is done in e.g. propagateCancel in context.go. It is already specified for WithTimeout and WithDeadline, whose descriptions I have simplified here. Change-Id: I6b30605decb8c0b7c1296c3f8852f9ad305ad4b7 Reviewed-on: https://go-review.googlesource.com/5022Reviewed-by: Sameer Ajmani <sameer@golang.org>
-
- 18 Feb, 2015 1 commit
-
-
Andrew Gerrand authored
Change-Id: Ie44649d1d5594ba140e673eaafb94fecead561ee Reviewed-on: https://go-review.googlesource.com/5214Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 12 Feb, 2015 1 commit
-
-
Bryan C. Mills authored
The current example leaks the DoSomethingSlow goroutine for an arbitrarily long time. In a real server, that can lead to an out-of-memory failure during events such as network outages; a more careful version of that example would be too long for a simple package doc. Fortunately, there are other short, common patterns using Done that don't leak and don't require a lot of explanation. Let's use one of those instead. Change-Id: I0ad0c6121d06b757a397e0e71be9e01ccfd75f77 Reviewed-on: https://go-review.googlesource.com/4490Reviewed-by: Andrew Gerrand <adg@golang.org>
-
- 10 Feb, 2015 3 commits
-
-
Andy Balholm authored
This provides a CharsetReader function for xml.Decoder. Change-Id: Id00787bbdee90d267d38c84c98a06f9e10d93336 Reviewed-on: https://go-review.googlesource.com/4420Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
Nigel Tao authored
LockSystem.Confirm now takes two names (a src and a dst), and returns a func() instead of a 1-method Releaser. We now pass 25 of 30 "locks" litmus tests: - 4 failures are due to PROPFIND / PROPPATCH not being implemented. - 1 failure is due to shared locks being unsupported. - 3 warnings are also due to PROPFIND / PROPPATCH. - 1 failure (cond_put_corrupt_token) is due to returning 412 (Precondition Failed) instead of 423 (Locked), but IIUC the spec says to return 412. - 11 tests were skipped, presumably due to earlier failures. Change-Id: I3f4c178cdc4b99c6acb7f59783b4fd9b94f606ec Reviewed-on: https://go-review.googlesource.com/3860Reviewed-by: Dave Cheney <dave@cheney.net>
-
Nigel Tao authored
instead of FileSystem.Rename directly. Dir.Rename's behavior wrt overwriting existing files and directories is OS-dependent. Fixes golang/go#9786 Change-Id: If42728caa6f0f38f8e3d6b1fcdda8c2d272080d6 Reviewed-on: https://go-review.googlesource.com/4341Reviewed-by: Nick Cooper <nmvc@google.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
- 09 Feb, 2015 1 commit
-
-
Damien Neil authored
Change-Id: Iee673c97e6a3b779c3d8ba6bb1b5f2b2e2032b86 Reviewed-on: https://go-review.googlesource.com/3911Reviewed-by: Sameer Ajmani <sameer@golang.org>
-
- 06 Feb, 2015 4 commits
-
-
Mikio Hara authored
This change implements ICMP extensions for interface and next-hop identification which are used for route trace applications as described in RFC 5837. Change-Id: I2435109b5e766e743b894b0280a537324975489d Reviewed-on: https://go-review.googlesource.com/3112Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Aaron Jacobs authored
The point of the DoSomething function is to protect the user from DoSomethingSlow, which presumably doesn't support returning early upon cancellation and deadline expiration (or else DoSomething wouldn't need to exist). Since most of the point of the Context object is communicating deadline and cancellation, it is misleading for DoSomethingSlow to accept a context object. A function like DoSomething is only likely to be written when wrapping other code that doesn't properly support contexts. Change-Id: Ibdef5b7ed71387ba6a09179ef2f911fc3f98e40a Reviewed-on: https://go-review.googlesource.com/3902Reviewed-by: Sameer Ajmani <sameer@golang.org>
-
Mikio Hara authored
This change implements ICMP multi-part message marshaler, parser and extensions for MPLS which are used for route trace applications as described in RFC 4950. API breaking changes: type MessageBody interface, Len() int type Extension interface, Len() int type Extension interface, Marshal() ([]byte, error) are replaced with type MessageBody interface, Len(int) int type Extension interface, Len(int) int type Extension interface, Marshal(int) ([]byte, error) Change-Id: Iee1f2e03916d49b8dfe3a89fe682c702d40ecc85 Reviewed-on: https://go-review.googlesource.com/2794Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Nigel Tao authored
Change-Id: I86f0c7695b7888c9cfed4386734cce9f0e05e3fd Reviewed-on: https://go-review.googlesource.com/3982Reviewed-by: David Symonds <dsymonds@golang.org>
-
- 04 Feb, 2015 4 commits
-
-
Nigel Tao authored
Change-Id: Idcd7c225efda94021ba18ca33f3fe7e8565140fe Reviewed-on: https://go-review.googlesource.com/3861Reviewed-by: Dave Cheney <dave@cheney.net> Reviewed-by: Nick Cooper <nmvc@google.com>
-
Nigel Tao authored
Forbidden during copyFiles. Change-Id: Ica2df08e1e4086c0c6db5a4c90bcf4fefc850bc7 Reviewed-on: https://go-review.googlesource.com/3835Reviewed-by: Dave Cheney <dave@cheney.net>
-
Nigel Tao authored
http://golang.org/pkg/net/http/#ResponseWriter says that "Changing the header after a call to WriteHeader (or Write) has no effect." Change-Id: Ica749e1475a93d535adb1300bc599d5cfe49a94f Reviewed-on: https://go-review.googlesource.com/3689Reviewed-by: Nick Cooper <nmvc@google.com> Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
Nigel Tao authored
This helps line up HTTP events (in the Go code) with the litmus test suite (C code). Change-Id: I2d0847069ae1304948ba1219b63cd438a4fa921c Reviewed-on: https://go-review.googlesource.com/3760Reviewed-by: Robert Stepanek <robert.stepanek@gmail.com> Reviewed-by: Nick Cooper <nmvc@google.com> Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
- 02 Feb, 2015 2 commits
-
-
Robert Stepanek authored
Change-Id: I285f93e562ca0c6bdc6168e6c47b28c7caef7cf5 Reviewed-on: https://go-review.googlesource.com/3501Reviewed-by: Nick Cooper <nmvc@google.com> Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
Nigel Tao authored
Change-Id: I22d47bc4a07911a8c7c57a2db83f5c8ffe1c420c Reviewed-on: https://go-review.googlesource.com/3565Reviewed-by: Nick Cooper <nmvc@google.com> Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
- 01 Feb, 2015 1 commit
-
-
Nigel Tao authored
just new files. Section 10.5 says the Lock-Token applies when creating a new lock, not just when (implicitly) creating a new file. The litmus test expects this. Change-Id: I8746154c9baba9a90b4e9db79cadb6839fc170c7 Reviewed-on: https://go-review.googlesource.com/3567Reviewed-by: Dave Cheney <dave@cheney.net>
-
- 30 Jan, 2015 5 commits
-
-
Mikio Hara authored
Change-Id: I1d91ddf7fb4eebd4782f0621446ec2820d132788 Reviewed-on: https://go-review.googlesource.com/3562Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
Change-Id: If1243dd2d79824933d896a8c4b31db8c247d0c21 Reviewed-on: https://go-review.googlesource.com/3561Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Nigel Tao authored
These occur after a heap.Remove call, and heap.Remove calls byExpiry.Pop, which already sets n.byExpiryIndex to -1. The memLS.consistent method in lock_test.go checks that the expiry fields are all consistent. Change-Id: I09f5d02999e4635f15d1723f89a86b951ed95950 Reviewed-on: https://go-review.googlesource.com/3563Reviewed-by: Dave Cheney <dave@cheney.net> Reviewed-by: Nick Cooper <nmvc@google.com>
-
Nigel Tao authored
Also add a -port flag to litmus_test_server. 13 of 13 copymove tests from the litmus suite pass, as does 16 of 16 basic tests. Change-Id: Idf92cad281e15db7d4d62e28e366ea7bfa89e564 Reviewed-on: https://go-review.googlesource.com/3470Reviewed-by: Nick Cooper <nmvc@google.com> Reviewed-by: Robert Stepanek <robert.stepanek@gmail.com> Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
Mikio Hara authored
Change-Id: I0e4245c26f2a19b366cd22fabefa8d0e65c6b2cc Reviewed-on: https://go-review.googlesource.com/3560Reviewed-by: Dave Cheney <dave@cheney.net>
-
- 29 Jan, 2015 4 commits
-
-
Mikio Hara authored
Change-Id: I12b41d16b49415081242e06b25a7106a4a0c0442 Reviewed-on: https://go-review.googlesource.com/3402Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
Change-Id: I3cf716c9ae02d7daa0d5a11249c3b58f6c8be2fe Reviewed-on: https://go-review.googlesource.com/3403Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
Change-Id: I06585ba7e40c1653139520f3d67d96e5d86302ac Reviewed-on: https://go-review.googlesource.com/3401Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
This change copies a few code fragments from https://golang.org/cl/13422044. Change-Id: I7ceae3a59e15dc9f9ef4b2b64a41753aa9d6798b Reviewed-on: https://go-review.googlesource.com/3400Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 27 Jan, 2015 3 commits
-
-
Robert Stepanek authored
This change contains a proposal for marshalling multistatus responses to support the lock and property systems. In addition, a type for properties is defined for the to-be-implemented property system. Change-Id: I3d768d8d61bb9495bc70e4699dee8958d444147f Reviewed-on: https://go-review.googlesource.com/3160Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
Nigel Tao authored
Change-Id: I92f4d1ede193302af31c56452b425e7ac20c0764 Reviewed-on: https://go-review.googlesource.com/3177Reviewed-by: Dave Cheney <dave@cheney.net>
-
Nigel Tao authored
file name. This fixes inconsistent stat names after a file is renamed. Change-Id: Ie90f8abaa31d46a87834266053b61d7770f854e2 Reviewed-on: https://go-review.googlesource.com/3051Reviewed-by: Nick Cooper <nmvc@google.com> Reviewed-by: Dave Cheney <dave@cheney.net>
-
- 22 Jan, 2015 1 commit
-
-
Norberto Lopes authored
Some servers return a websocket url without a port. This patch automatically adds :80 for ws and :443 for wss. Change-Id: Ifdcdbda8f87c994a5f351234c83bf4a07be34ea2 Reviewed-on: https://go-review.googlesource.com/2210Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
-
- 21 Jan, 2015 1 commit
-
-
Nigel Tao authored
Change-Id: Ieb3d550d06adc7457ed6870b0dd5fbbfede7c488 Reviewed-on: https://go-review.googlesource.com/3074Reviewed-by: Dave Cheney <dave@cheney.net>
-
- 20 Jan, 2015 1 commit
-
-
Robert Stepanek authored
Change-Id: Ib51221be5dbf3a8a4f624ca3bff4b283f311e43b Reviewed-on: https://go-review.googlesource.com/2757Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
- 17 Jan, 2015 2 commits
-
-
Nigel Tao authored
It will be used by the WebDAV MOVE method. Change-Id: Iacbcf58af4da0d169271661324537825d4ff887c Reviewed-on: https://go-review.googlesource.com/2952Reviewed-by: Dave Cheney <dave@cheney.net>
-
Nigel Tao authored
Change-Id: I1e109180673cf3caff4413d12b77422bb072ac50 Reviewed-on: https://go-review.googlesource.com/2950Reviewed-by: Dave Cheney <dave@cheney.net> Reviewed-by: Nick Cooper <nmvc@google.com>
-
- 16 Jan, 2015 2 commits
-
-
Nigel Tao authored
Fix Dir.OpenFile to not return a nil *os.File (a concrete type) when it should return a nil webdav.File (an interface type). Fix memFS.RemoveAll to return nil error instead of os.ErrNotExist when removing a non-existant file, matching os.RemoveAll's documented semantics. Change-Id: I84dfb404aca30e084cd46d6bdc94655aab718bc0 Reviewed-on: https://go-review.googlesource.com/2932Reviewed-by: Nigel Tao <nigeltao@golang.org>
-
Mikio Hara authored
Also fixes parseProtocolNumbers to make it possible to grab the recently added keyword "deprecated" correctly. Change-Id: I431da33a722eab9aa13ce1834acab4e9e6346bfd Reviewed-on: https://go-review.googlesource.com/2852Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 15 Jan, 2015 3 commits
-
-
Nigel Tao authored
Also fix memFile.Readdir(n) to return nil error when n <= 0, to match package os. Fix memFile.Write to fail when writing to directories. Avoid taking the node lock twice for memFile methods. Change-Id: I72b0753c9376c3889972662e0454efe67d73479a Reviewed-on: https://go-review.googlesource.com/2711Reviewed-by: Dave Cheney <dave@cheney.net> Reviewed-by: Nick Cooper <nmvc@google.com>
-
Mikio Hara authored
Change-Id: I52df24a3128bf6ba5ef82a66fe8b7305f6cc0549 Reviewed-on: https://go-review.googlesource.com/2796Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
Change-Id: Iff9ef2951093883d775373b798dc7612527d888c Reviewed-on: https://go-review.googlesource.com/2795Reviewed-by: Ian Lance Taylor <iant@golang.org>
-