Change-Id: I52df24a3128bf6ba5ef82a66fe8b7305f6cc0549
Reviewed-on: https://go-review.googlesource.com/2796Reviewed-by: Ian Lance Taylor <iant@golang.org>

Change-Id: Iff9ef2951093883d775373b798dc7612527d888c
Reviewed-on: https://go-review.googlesource.com/2795Reviewed-by: Ian Lance Taylor <iant@golang.org>

or infinity.

Change-Id: I3e3fba8e05a9c6c3db2240311a0813961db81849
Reviewed-on: https://go-review.googlesource.com/2535Reviewed-by: Dave Cheney <dave@cheney.net>

Change-Id: If5745dcc1d66fdaa083d4085440b1535aa75e0da
Reviewed-on: https://go-review.googlesource.com/2430Reviewed-by: Dave Cheney <dave@cheney.net>

Change-Id: I9edeffebf3f22880c4e2d14fa3754415757dcdca

ICMP extension structures allow a few existing ICMP error messages to
convey extra information for troubleshooting; especially the root cause
of why the original datagram could not be delivered.

This CL adds generic support for ICMP extension stuructures to
DstUnreach, TimeExceeded and ParamProb structs. Specific extensions such
as MPLS label-stack, interface and next-hop identification will be
inplemneted in separate followup CLs.

Change-Id: I90798c135bdf76b806e2dde2bdd57c2c11d7e7e9

benchmark                 old ns/op     new ns/op     delta
BenchmarkMemFileWrite     8498028       625563        -92.64%

Change-Id: Iec7dd3931c891c9d6d9d5c6ccd05300b031a5f86

Change-Id: Ic0c1ac9c328360fb591e040c3c837b2ca6234193

- Handles absence of If header.
- Reject Mkcol requests with a body.
- Delete on non-existant item should return 404.
- Support OPTIONS request.
- Ensure logger is invoked for all requests.

See original CL: golang.org/cl/178930043

Change-Id: Ic96aed10c54bb5ed0641092178ad6f15b1440cb4

filesystem.

See original mercurial CL: golang.org/cl/171700045

Change-Id: Ib18277df4f7f232afdf6331f4bca5aaa3b00b83b

Change-Id: Ic73c693104b0785a261322c4c2a1e5333d5c378c

Fixes #9253

Change-Id: I29ad04698e20c6e4d04a2b5b161693ac7cd482a2

We cannot use net.ReadFrom on darwin because a) net.ReadFrom and
net.ReadFromIP unconditionally try to strip off ipv4 header due to
and c) icmp.ListenPacket calls ipv4.PacketConn internally.

Instead, we use ipv4.PacketConn.ReadFrom that calls net.ReadMsgIP
internally to prevent icmp.ReadFrom from returning corrupted ICMP
message.

Fixes #9395.

Change-Id: I269f3724de72bf37eb26921c251c2acb1c720fa3

The wire format of parameter problem message is slightly different
between ICMPv4 and ICMPv6. We need to distinguish each message's
protocol family for avoiding dropping wrong wire format stuff on the
wire.

This is an API breaking change.

type MessageBody interface, Marshal() ([]byte, error)

is replaced with

type MessageBody interface, Marshal(int) ([]byte, error)

Fixes #9394.

Change-Id: Id692c76f85a2714dd011342e648b31395ca668bf

For now we see three types of behaviors: conventional BSD, FreeBSD and
other that including Linux, OpenBSD, Solaris and Windows.

Change-Id: Iff7efe50b40bd3537b6ed8f02245552d8216c4f3

Fixes #9281

Change-Id: I144afc9736d3d0ba1cdd2693efd0c7f07b1b8bf3

Change-Id: I09adabf07366426451303f72b0f2e6a0869b7508

Change-Id: Ifab0fdaec1d810d268b7c19ad30f476802203b37

There is no circular dependencies, no need to hesitate to use it.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/185900043

This is an API breaking change.

method (*ICMPFilter) Set(ICMPType, bool)

is now replaced with

method (*ICMPFilter) Accept(ICMPType)
method (*ICMPFilter) Block(ICMPType)

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182450043

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/179510043

Also fixes typos.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182410043

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/183040043

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/183030043

This CL makes icmp an external package.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182370043

This CL adds PacketConn struct that implements net.PacketConn
interface.

Update golang/go#9166

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182110043

This CL adds ParseIPv4Header for parsing an IPv4 header in ICMP
error message. We cannot use ipv4.ParseHeader for it because they
are different things processed by either ip_input or icmp_input.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/184850043

This CL introduces few ICMP error message body types such as
DstUnreach, PacketTooBig, TimeExceeded or ParamProb.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/183850043

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/182950043

According to github.com/opensource-apple/xnu.git, IP_STRIPHDR sticky
socket option was introduced in xnu-517 (Darwin 7.0, OS X 10.3).

LGTM=iant
R=iant, gobot
CC=golang-codereviews
https://golang.org/cl/176480043

This reduces allocation and copy ops with net.IPConn-based
ipv4.PacketConn on latest darwin kernels.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/184770043

This CL adds Header type and ParseHeader function for convenience
in parsing ICMP error messages such as destination unreachable,
packet too big, time exceeded and parameter problem.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/177530043

LGTM=iant
R=iant, bradfitz
CC=golang-codereviews
https://golang.org/cl/173670044

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/183750044

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/181200043