Commits · f4b625ec9b21d620bb5ce57f2dfc3e08ca97fce6 · go / net

07 Oct, 2016 5 commits

trace: don't allocate all events upfront · f4b625ec

Radu Berinde authored Oct 05, 2016

SetMaxEvent allocates storage for all events, which is very expensive
if we want to set a high value; even with small values, the
unnecessary allocation of the initial slice is measurable.

We improve the performance by having a few events preallocated as part
of the trace, and appending as necessary. We also co-locate the flags
in event which makes it smaller (by a word).

We also add a set of benchmarks; before and after amortized cost
per-event is shown:

name                    old time/op  new time/op  delta
Trace_Default_2-32      1.19µs ± 1%  0.96µs ± 0%  -18.94%
Trace_Default_10-32      579ns ± 0%   635ns ± 1%   +9.82%
Trace_Default_100-32     463ns ± 1%   466ns ± 1%     ~
Trace_Default_1000-32    451ns ± 1%   451ns ± 0%     ~
Trace_Default_10000-32   451ns ± 2%   449ns ± 1%     ~
Trace_10_2-32           1.41µs ± 1%  0.96µs ± 1%  -31.74%
Trace_10_10-32           623ns ± 1%   634ns ± 1%   +1.73%
Trace_10_100-32          469ns ± 1%   466ns ± 1%     ~
Trace_10_1000-32         452ns ± 1%   453ns ± 2%     ~
Trace_10_10000-32        451ns ± 1%   449ns ± 1%     ~
Trace_100_2-32          2.78µs ± 2%  0.97µs ± 1%  -65.28%
Trace_100_10-32          912ns ± 1%   637ns ± 1%  -30.23%
Trace_100_100-32         479ns ± 1%   541ns ± 0%  +12.77%
Trace_100_1000-32        510ns ± 0%   541ns ± 1%   +6.08%
Trace_100_10000-32       514ns ± 1%   540ns ± 0%   +5.14%
Trace_1000_2-32         17.2µs ± 1%   1.0µs ± 1%  -94.39%
Trace_1000_10-32        3.90µs ± 1%  0.64µs ± 0%  -83.68%
Trace_1000_100-32        814ns ± 1%   542ns ± 0%  -33.46%
Trace_1000_1000-32       503ns ± 1%   581ns ± 0%  +15.56%
Trace_1000_10000-32     1.28µs ± 2%  1.03µs ± 1%  -19.68%

Change-Id: I5bbc12153a9f30dff821ef139583cb1c07a11069
Reviewed-on: https://go-review.googlesource.com/30615Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

f4b625ec

Revert "trace: don't allocate all events upfront" · 9b4f494e

Brad Fitzpatrick authored Oct 07, 2016

This reverts commit If7c68bb1809fb92fa5d06cb6640be5e09e1f131f.

Reason for revert: breaks the build for Go 1.6 or below due to use of Go 1.7+ only features.

Original change's description:
> trace: don't allocate all events upfront
> 
> SetMaxEvent allocates storage for all events, which is very expensive
> if we want to set a high value; even with small values, the
> unnecessary allocation of the initial slice is measurable.
> 
> We improve the performance by having a few events preallocated as part
> of the trace, and appending as necessary. We also co-locate the flags
> in event which makes it smaller (by a word).
> 
> We also add a set of benchmarks; before and after amortized cost
> per-event is shown:
> 
> name                 old time/op  new time/op  delta
> Trace/0-2-32         1.19µs ± 1%  0.96µs ± 0%  -18.94%  (p=0.008 n=5+5)
> Trace/0-10-32         579ns ± 0%   635ns ± 1%   +9.82%  (p=0.008 n=5+5)
> Trace/0-100-32        463ns ± 1%   466ns ± 1%     ~     (p=0.190 n=5+5)
> Trace/0-1000-32       451ns ± 1%   451ns ± 0%     ~     (p=0.984 n=5+5)
> Trace/0-10000-32      451ns ± 2%   449ns ± 1%     ~     (p=0.492 n=5+5)
> Trace/10-2-32        1.41µs ± 1%  0.96µs ± 1%  -31.74%  (p=0.008 n=5+5)
> Trace/10-10-32        623ns ± 1%   634ns ± 1%   +1.73%  (p=0.008 n=5+5)
> Trace/10-100-32       469ns ± 1%   466ns ± 1%     ~     (p=0.357 n=5+5)
> Trace/10-1000-32      452ns ± 1%   453ns ± 2%     ~     (p=0.913 n=5+5)
> Trace/10-10000-32     451ns ± 1%   449ns ± 1%     ~     (p=0.175 n=5+5)
> Trace/100-2-32       2.78µs ± 2%  0.97µs ± 1%  -65.28%  (p=0.008 n=5+5)
> Trace/100-10-32       912ns ± 1%   637ns ± 1%  -30.23%  (p=0.008 n=5+5)
> Trace/100-100-32      479ns ± 1%   541ns ± 0%  +12.77%  (p=0.008 n=5+5)
> Trace/100-1000-32     510ns ± 0%   541ns ± 1%   +6.08%  (p=0.008 n=5+5)
> Trace/100-10000-32    514ns ± 1%   540ns ± 0%   +5.14%  (p=0.008 n=5+5)
> Trace/1000-2-32      17.2µs ± 1%   1.0µs ± 1%  -94.39%  (p=0.008 n=5+5)
> Trace/1000-10-32     3.90µs ± 1%  0.64µs ± 0%  -83.68%  (p=0.008 n=5+5)
> Trace/1000-100-32     814ns ± 1%   542ns ± 0%  -33.46%  (p=0.008 n=5+5)
> Trace/1000-1000-32    503ns ± 1%   581ns ± 0%  +15.56%  (p=0.008 n=5+5)
> Trace/1000-10000-32  1.28µs ± 2%  1.03µs ± 1%  -19.68%  (p=0.008 n=5+5)
> 
> Change-Id: If7c68bb1809fb92fa5d06cb6640be5e09e1f131f
> Reviewed-on: https://go-review.googlesource.com/30374
> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
> TryBot-Result: Gobot Gobot <gobot@golang.org>
> Reviewed-by: Ian Lance Taylor <iant@golang.org>
> 

Change-Id: I7cf25464ae836489e0af4a59a4d534a5d25ee352
Reviewed-on: https://go-review.googlesource.com/30650Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

9b4f494e

lif: rename internal types and constants generated by cgo · 084869ab

Mikio Hara authored Oct 07, 2016

To match up with other packages that work with IP protocol stack.

Change-Id: Idc3ee5b2399c4982dbd9114aac441f6d7452aeef
Reviewed-on: https://go-review.googlesource.com/30576
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

084869ab

ipv6: rename internal types and constants generated by cgo · 30df40a6

Mikio Hara authored Oct 07, 2016

To match up with other packages that work with IP protocol stack.

Change-Id: I1f4eb76051964766113914c9698233022e73d5eb
Reviewed-on: https://go-review.googlesource.com/30575
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

30df40a6

ipv4: rename internal types and constants generated by cgo · a14f429b

Mikio Hara authored Oct 07, 2016

To match up with other packages that work with IP protocol stack.

Change-Id: I2d20e4194617b05b6b46d6fba5df1f6c12ae2793
Reviewed-on: https://go-review.googlesource.com/30574
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

a14f429b

06 Oct, 2016 5 commits

trace: don't allocate all events upfront · 88c1a61b

Radu Berinde authored Oct 05, 2016

SetMaxEvent allocates storage for all events, which is very expensive
if we want to set a high value; even with small values, the
unnecessary allocation of the initial slice is measurable.

We improve the performance by having a few events preallocated as part
of the trace, and appending as necessary. We also co-locate the flags
in event which makes it smaller (by a word).

We also add a set of benchmarks; before and after amortized cost
per-event is shown:

name old time/op new time/op delta
Trace/0-2-32 1.19µs ± 1% 0.96µs ± 0% -18.94% (p=0.008 n=5+5)
Trace/0-10-32 579ns ± 0% 635ns ± 1% +9.82% (p=0.008 n=5+5)
Trace/0-100-32 463ns ± 1% 466ns ± 1% ~ (p=0.190 n=5+5)
Trace/0-1000-32 451ns ± 1% 451ns ± 0% ~ (p=0.984 n=5+5)
Trace/0-10000-32 451ns ± 2% 449ns ± 1% ~ (p=0.492 n=5+5)
Trace/10-2-32 1.41µs ± 1% 0.96µs ± 1% -31.74% (p=0.008 n=5+5)
Trace/10-10-32 623ns ± 1% 634ns ± 1% +1.73% (p=0.008 n=5+5)
Trace/10-100-32 469ns ± 1% 466ns ± 1% ~ (p=0.357 n=5+5)
Trace/10-1000-32 452ns ± 1% 453ns ± 2% ~ (p=0.913 n=5+5)
Trace/10-10000-32 451ns ± 1% 449ns ± 1% ~ (p=0.175 n=5+5)
Trace/100-2-32 2.78µs ± 2% 0.97µs ± 1% -65.28% (p=0.008 n=5+5)
Trace/100-10-32 912ns ± 1% 637ns ± 1% -30.23% (p=0.008 n=5+5)
Trace/100-100-32 479ns ± 1% 541ns ± 0% +12.77% (p=0.008 n=5+5)
Trace/100-1000-32 510ns ± 0% 541ns ± 1% +6.08% (p=0.008 n=5+5)
Trace/100-10000-32 514ns ± 1% 540ns ± 0% +5.14% (p=0.008 n=5+5)
Trace/1000-2-32 17.2µs ± 1% 1.0µs ± 1% -94.39% (p=0.008 n=5+5)
Trace/1000-10-32 3.90µs ± 1% 0.64µs ± 0% -83.68% (p=0.008 n=5+5)
Trace/1000-100-32 814ns ± 1% 542ns ± 0% -33.46% (p=0.008 n=5+5)
Trace/1000-1000-32 503ns ± 1% 581ns ± 0% +15.56% (p=0.008 n=5+5)
Trace/1000-10000-32 1.28µs ± 2% 1.03µs ± 1% -19.68% (p=0.008 n=5+5)

Change-Id: If7c68bb1809fb92fa5d06cb6640be5e09e1f131f
Reviewed-on: https://go-review.googlesource.com/30374
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

88c1a61b

ipv6: don't refer to cgo-generated union field · 2a824cf9

Mikio Hara authored Oct 04, 2016

The size of sockaddr_storage is fixed for interoperability on each
platform. There is no need to depend on changable cgo-generated
offset values.

Change-Id: I54b775b2a8c86d969a6da0398a335075f0cbe3df
Reviewed-on: https://go-review.googlesource.com/30178
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

2a824cf9

ipv4: don't refer to cgo-generated union field · 534e1870

Mikio Hara authored Oct 04, 2016

The size of sockaddr_storage is fixed for interoperability on each
platform. There is no need to depend on changable cgo-generated
offset values.

Change-Id: I7469fe330d49867bbdbdfae128834140244925ec
Reviewed-on: https://go-review.googlesource.com/30177
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

534e1870

ipv6: add support for solaris · a7769702

Mikio Hara authored Oct 03, 2016

This change adds support for Solaris.

To read and write IPv6 ancillary data using ControlMessage, ipv6 pacakge
requires https://go-review.googlesource.com/30171/

Note: Unlike other platforms, Solaris seems to have a few restrictions
on ICMP property access via raw IP sockets. At least applications are
prohibited from using IPV6_CHECKSUM option for ICMP transport.

Fixes golang/go#17324.

Change-Id: Ie014665d94ae6e4955c95d3eea88db90332e20bd
Reviewed-on: https://go-review.googlesource.com/30176
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

a7769702

ipv4: add support for solaris · c8c327cf

Mikio Hara authored Oct 03, 2016

This change adds support for Solaris.

To read and write IPv4 ancillary data using ControlMessage, ipv4 pacakge
requires https://go-review.googlesource.com/30171/

Note: Unlike other platforms, Solaris seems to have a few restrictions
on ICMP property access via raw IP sockets. At least applications are
prohibited from using IP_RECVTTL option for ICMP transport.

Fixes golang/go#17323.

Change-Id: Icb6dfa3c8eced28d14693ddfea4601301999d735
Reviewed-on: https://go-review.googlesource.com/30175
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

c8c327cf

03 Oct, 2016 4 commits

ipv6: rename thunk_linux_386.s to sys_linux_386.s · ffe101cc

Mikio Hara authored Oct 03, 2016

Change-Id: I8f05f473bb78336dd1ba788cfa09fc02797eb8dd
Reviewed-on: https://go-review.googlesource.com/30174Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

ffe101cc

ipv4: rename thunk_linux_386.s to sys_linux_386.s · c67f3816

Mikio Hara authored Oct 03, 2016

Change-Id: I6b58c698527a1ebcb34fd1e08834bb5d7f33f49a
Reviewed-on: https://go-review.googlesource.com/30173Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

c67f3816

http2: remove duplicate map lookups in checkConnHeaders · 0f2be02c

Brad Fitzpatrick authored Oct 01, 2016

Change-Id: I3fa5b27a4846807e8ed1265d696929037b77861b
Reviewed-on: https://go-review.googlesource.com/30160Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

0f2be02c

websocket: use net.Dialer to open tcp connection · 819f4c53

Cezar Sa Espinola authored Jul 14, 2015

This change adds a Dialer field to websocket.Config struct. If this
value is set the Dialer will be used. If it's nil, DialConfig will
create an empty Dialer that will maintain the original behavior.

Because before Go 1.3 there was no crypto/tls.DialWithDialer function,
the Dialer will be ignored when opening TLS connections in these
versions.

Fixes golang/go#9198.

Change-Id: If8b5c3c47019a3d367c436e3e60eb54bf0276184
Reviewed-on: https://go-review.googlesource.com/12191Reviewed-by: Russ Cox <rsc@golang.org>

819f4c53

01 Oct, 2016 3 commits

http2: mention bogus header value in error messages · cd95c68b

Ivan Babrou authored Oct 01, 2016

Change-Id: I69d713341b878a2343bb85fb2de2ef49441fd16d
Reviewed-on: https://go-review.googlesource.com/30098
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

cd95c68b

trace: spelling consistency tweaks · 1f79cc9b

Sam Whited authored Oct 01, 2016

s/customise/customize/
s/authorisation/authorization/

Change-Id: I23afdca1b773ef9572794555dfb768c9ded90ab8
Reviewed-on: https://go-review.googlesource.com/30159Reviewed-by: Ian Lance Taylor <iant@golang.org>

1f79cc9b

http2: don't sniff Request.Body on 100-continue requests in Transport · 0d8126fc

Brad Fitzpatrick authored Sep 30, 2016

Tests in net/http: TestNoSniffExpectRequestBody_h2

Updates golang/go#16002

Change-Id: Ib5255c14f0a8fdafd36077b86442dff213815567
Reviewed-on: https://go-review.googlesource.com/30150
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

0d8126fc

30 Sep, 2016 2 commits

http2: in Server, disarm connection's ReadTimeout after first request · 69729301

Brad Fitzpatrick authored Sep 30, 2016

Fix a regression from Go 1.5 to Go 1.6: when we introduced automatic
HTTP/2 support in Go 1.6, we never handled Server.ReadTimeout. If a
user set ReadTimeout, the net/http package would set the read deadline
on the connection during the TLS handshake, but then the http2 package
would never disarm it, killing the likely-still-in-use connection
after the timeout period.

This CL changes it to disarm the timeout after the first request
headers, similar to net/http.Server.

Unlike net/http.Server, we don't re-arm it on each idle period,
because the definition of idle is more complicated with HTTP/2.

No tests here for now. Tests will be in the go repo once all the knobs
are in place and this is re-bundled into std, testing both http1 and
http2.

Updates golang/go#16450 (minimal fix for now)
Updates golang/go#14204 (considering a new http1+http2 IdleTimeout knob)

Change-Id: Iaa1570c118efda7dc0a65ba84cd77885699ec8fc
Reviewed-on: https://go-review.googlesource.com/30077Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

69729301

http2: add Transport support for IdleConnTimeout · a333c534

Brad Fitzpatrick authored Sep 29, 2016

Tests will be in the go repo's net/http package when this
package is re-bundled into std.

Updates golang/go#16808 (fixes after bundle into std)

Change-Id: Iad31dc120bc008b1e9679bf7b2b988aac9c893c8
Reviewed-on: https://go-review.googlesource.com/30075
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

a333c534

29 Sep, 2016 4 commits

http: fix build on Go 1.6 and below · 8058fc7b

Brad Fitzpatrick authored Sep 29, 2016

https://golang.org/cl/29965 adding ClientConn.Ping support introduced
a build failure on Go versions before 1.7.

Fixes golang/go#17286

Change-Id: Ibfb565e7d823a436e58dc833973d7bdb41b7de5a
Reviewed-on: https://go-review.googlesource.com/30071
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>

8058fc7b

http2: implement Ping method on ClientConn · ed0556cc

Olivier Poitrey authored Sep 29, 2016

This new method sends a PING frame with random payload to the peer and
wait for a PING ack with the same payload.

In order to support cancellation and deadling, the Ping method takes a
context as argument.

Fixes golang/go#15475

Change-Id: I340133a67717af89556837cc531a885d116eba59
Reviewed-on: https://go-review.googlesource.com/29965Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

ed0556cc

x/net/http2: use request url scheme · fbd690d9

ayanamist authored Sep 29, 2016

The existing implementation has a hardcoded "https" scheme for
all request, since it allows http scheme in the request, it should
use the scheme in the request url.

Fixes golang/go#17257

Change-Id: Ibd9528df0328d7630ee94a006db694645625cdc9
Reviewed-on: https://go-review.googlesource.com/29975
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

fbd690d9

lif: new package · 9f0e377a

Mikio Hara authored Sep 27, 2016

This change introduces a package that provides basic functions for the
manipulation of logical network interfaces, interface addresses and
data links on Solaris.

As BSD variants implement routing socket and routing messages, Linux
implements netlink socket and netlink messages, Solaris implements
STREAMS-like interface for reading, writing network facility
information inside the kernel. The package wraps various I/O control
calls which involve message exchanges between kernel protocol modules
in exposed APIs.

At present, the package supports Solaris 11 or above.

Updates golang/go#7177.

Change-Id: I192d85e53b0bee942dfefca0f73a3eb94ab8bfe9
Reviewed-on: https://go-review.googlesource.com/29893Reviewed-by: Ian Lance Taylor <iant@golang.org>

9f0e377a

24 Sep, 2016 3 commits

route: fix typo · f09c4662

Mikio Hara authored Sep 24, 2016

Change-Id: I41d449e071f1d40bdc69288e7290af168b6b0d3c
Reviewed-on: https://go-review.googlesource.com/29693Reviewed-by: Ian Lance Taylor <iant@golang.org>

f09c4662

ipv4: fix typo · 99a55505

Mikio Hara authored Sep 24, 2016

Change-Id: Iaec7505bea3ea29cd58147b6057f03a4c7f0861c
Reviewed-on: https://go-review.googlesource.com/29694Reviewed-by: Ian Lance Taylor <iant@golang.org>

99a55505

ipv6: fix typo · 6ea239cd

Mikio Hara authored Sep 24, 2016

Change-Id: I2e0a8f0e344a2fc31b3d40e0b9f3812dbbd75569
Reviewed-on: https://go-review.googlesource.com/29695Reviewed-by: Ian Lance Taylor <iant@golang.org>

6ea239cd

21 Sep, 2016 1 commit

route: test helper code cleanup · 6d3beaea

Mikio Hara authored Sep 11, 2016

Rename method receivers of propVirtual and make the String method of
Inet4Addr use of a pointer receiver.

Change-Id: I422593cf4028d83f856efa55c631f69fdce0514d
Reviewed-on: https://go-review.googlesource.com/28993
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

6d3beaea

20 Sep, 2016 1 commit

http2: fix broken tests · f4fe4abe

Tom Bergan authored Sep 20, 2016

testServerResponse had dead code -- it was not checking the return
value from the handler func. This fix revealed two broken tests, which
were also fixed.

Change-Id: I7cd6f6c71dbd909fa3b0aff7f98a47dade42913b
Reviewed-on: https://go-review.googlesource.com/29434Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

f4fe4abe

16 Sep, 2016 1 commit

x/net/http2: Fix various typos in doc comments. · 71a03591

Mike Appleby authored Sep 12, 2016

Change-Id: I1530dadf32cc85c25dc7c88b4e7b6ebbbbcb2d3a
Reviewed-on: https://go-review.googlesource.com/29241Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

71a03591

14 Sep, 2016 2 commits

ipv6: simplify init function for darwin · de35ec43

Mikio Hara authored Sep 12, 2016

Change-Id: If0bcd08de56518ec1dd79476bc37e276ae550d47
Reviewed-on: https://go-review.googlesource.com/28998
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

de35ec43

internel/nettest: add SupportsIPv6MulticastDeliveryOnLoopback · 26b81fba

Mikio Hara authored Sep 12, 2016

Also consolidate platform-dependent helper files.

Updates golang/go#17015.

Change-Id: Ibf09479762029ecc7229ab4bb233138e0d4e69d9
Reviewed-on: https://go-review.googlesource.com/28997
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

26b81fba

12 Sep, 2016 3 commits

http2: don't sniff first Request.Body byte in Transport until we have a conn · 749a502d

Brad Fitzpatrick authored Sep 12, 2016

bodyAndLength mutates Request.Body if Request.ContentLength == 0,
reading the first byte to determine whether it's actually empty or
just undeclared. But we did that before we checked whether our
connection was overloaded, which meant the caller could retry the
request on an new or lesser-loaded connection, but then lose the first
byte of the request.

Updates golang/go#17071 (needs bundle into std before fixed)

Change-Id: I996a92ad037b45bc49e7cf0801a2027bbbb3c920
Reviewed-on: https://go-review.googlesource.com/29074Reviewed-by: Gleb Stepanov <glebstepanov1992@gmail.com>
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

749a502d

http2: add Transport support for unicode domain names · 57c78209

Brad Fitzpatrick authored Sep 12, 2016

No tests, because tests are in std. (See TestTransportIDNA_h2)

Updates golang/go#13835

Change-Id: I0a327d9652ea5e6f32dfa279550915af61567bed
Reviewed-on: https://go-review.googlesource.com/29071
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Chris Broadfoot <cbro@golang.org>

57c78209

http2: fix bug where '*' as a valid :path value in Transport · 324491d7

Brad Fitzpatrick authored Sep 12, 2016

In the most recent commit (git 3a1f9e, CL 27632) I introduced a bug
where I improperly started rejecting an outgoing :path of '*'. That
CL was never vendored into std. Once I tried to vendor it and run the
tests, the tests failed due to this regression.

So, fix the bug and allow '*' (e.g. for OPTIONS requests). No test
updates because the tests are already in std, and now pass (again).

Change-Id: Ibb91a17145d381da0fd0ea193e8a1bd59f03c3fa
Reviewed-on: https://go-review.googlesource.com/29070Reviewed-by: Chris Broadfoot <cbro@golang.org>

324491d7

10 Sep, 2016 1 commit

icmp: don't step on recycled socket descriptors · cfe3c2a7

Mikio Hara authored Sep 03, 2016

This change fixes lazy socket descriptor handling in ListenPacket to
avoid treading on someone's socket descriptors which are recycled by
descriptor duplication. The issue happens when calling ListenPacket for
non-privileged ICMP endpoint concurrently.

Fixes golang/go#16969.

Change-Id: I4d7672535f5aeb2a0b71f8af2c7ba271a085f418
Reviewed-on: https://go-review.googlesource.com/28473
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

cfe3c2a7

07 Sep, 2016 1 commit

net: skip tests on OS X 10.8 to avoid a kernel panic · 9313baa1

Brad Fitzpatrick authored Sep 07, 2016

Temporary workaround until the problem is identified and a more
granular skip or fix is added.

Updates golang/go#17015

Change-Id: If3f940f9f318a3b41669fd6e870a17727d2fee82
Reviewed-on: https://go-review.googlesource.com/28587Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>

9313baa1

01 Sep, 2016 1 commit

http2: fix all vet warnings · 1358eff2

Brad Fitzpatrick authored Sep 01, 2016

Updates golang/go#16228
Updates golang/go#11041

Change-Id: I2b50c2f4bfaae2d9ad59bc78e1c7c3e807f08075
Reviewed-on: https://go-review.googlesource.com/28344
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

1358eff2

31 Aug, 2016 1 commit

internal/netreflect: fix test on nacl, plan9 and windows · 9bc2a334

Mikio Hara authored Aug 30, 2016

Change-Id: Ia274e47affd5fc2b9bdea077fa8043887044d0ec
Reviewed-on: https://go-review.googlesource.com/28110
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

9bc2a334

26 Aug, 2016 2 commits

ipv6: deduplicate socket option code · 6250b412

Mikio Hara authored Aug 24, 2016

Change-Id: I836cdf68901dc77bc4c086cabd9d43fd033fbf1d
Reviewed-on: https://go-review.googlesource.com/27736Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

6250b412

ipv4: deduplicate socket option code · b3982904

Mikio Hara authored Aug 24, 2016

Change-Id: If22f722cf87f7e5833b9c9aea0a078db83f37c26
Reviewed-on: https://go-review.googlesource.com/27734Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

b3982904