Commits · fa893e0b22c71d538aa6052a9fc90afe2f6ee293 · go / net

31 Oct, 2014 1 commit

go.net/ipv6: simplify syscall shims · fa893e0b

Mikio Hara authored Oct 31, 2014

This CL replaces syscall duplicates with tiny syscall shims to help
to add new platform support, to improve existing platform support.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/166910043

fa893e0b

30 Oct, 2014 1 commit
- go.net/ipv4: disable full stack tests on nacl, solaris · d3b1e661
  Mikio Hara authored Oct 30, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/165150043
```
  d3b1e661
24 Oct, 2014 4 commits
- go.net/ipv4: make use of go generate to create system adaptation files · bd815cb7
  Mikio Hara authored Oct 24, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/160800043
```
  bd815cb7
- go.net/ipv4: fix build with go1.2 · cd2d3ece
  Mikio Hara authored Oct 24, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/162110043
```
  cd2d3ece
- go.net/ipv6: fix build with go1.2 · 95186adc
  Mikio Hara authored Oct 24, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/163120043
```
  95186adc
- go.net/ipv4: skip ancillary data socket option tests on non-supported kernels · 81806109
  Mikio Hara authored Oct 24, 2014
```
It seems that old darwin kernels don't handle IP_RECVIF, IP_RECVDSTADDR correctly.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/158030043
```
  81806109
14 Oct, 2014 1 commit
- go.net/publicsuffix: update table to latest list from publicsuffix.org. · 4ea000c3
  Nigel Tao authored Oct 14, 2014
```
LGTM=dr.volker.dobler
R=dr.volker.dobler
CC=golang-codereviews
https://golang.org/cl/153390043
```
  4ea000c3
12 Oct, 2014 1 commit
- go.net/ipv4: ignore ENOPROTOOPT in ancillary data socket option tests · da5b8181
  Mikio Hara authored Oct 12, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/154260043
```
  da5b8181
11 Oct, 2014 2 commits
- go.net/ipv4: fix ancillary data socket option tests on old darwin · 68e5815b
  Mikio Hara authored Oct 11, 2014
```
Looks like their UDP stacks don't support ancillary data socket options.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/153330043
```
  68e5815b
- go.net/ipv6: rename payload_noncmsg.go to payload_nocmsg.go · 6a20d029
  Mikio Hara authored Oct 11, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/156950043
```
  6a20d029
09 Oct, 2014 3 commits

go.net/ipv4: fix openbsd build · 33d53303
Mikio Hara authored Oct 09, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/149690043
```
33d53303

go.net/internal/icmp: fix typo · d8abf884

Mikio Hara authored Oct 09, 2014

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/149680043

d8abf884

context: fix TestAllocs to account for ints in interfaces · 3ffb8fd1

Sameer Ajmani authored Oct 09, 2014

Recent runtime changes mean that these are stored indirectly, requiring additional allocation.

LGTM=adonovan
R=rsc, bradfitz, adonovan
CC=golang-codereviews
https://golang.org/cl/148590043

3ffb8fd1

07 Oct, 2014 2 commits

go.net/ipv6: add platform-dependent code · 91e38aee

Mikio Hara authored Oct 07, 2014

The syscall package of standard library is now locked down
and go.sys/unix is under curation. Also go.sys/unix doesn't
help supporting go1.3 and earlier users. There's no way to
extend this package without holding the platform adaptation
code.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/146290043

91e38aee

go.net/ipv4: make use of internal/nettest package · 2c60c92f
Mikio Hara authored Oct 07, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/155950043
```
2c60c92f

06 Oct, 2014 2 commits

go.net/internal/nettest: new package · fb10a5fd

Mikio Hara authored Oct 06, 2014

This CL factors out testing utilities used by both ipv4 and ipv6 packages.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/152070043

fb10a5fd

go.net/ipv4: make use of internal/{iana,icmp} packages · e5dac17b
Mikio Hara authored Oct 06, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/154880043
```
e5dac17b

04 Oct, 2014 1 commit

go.net/ipv4: restructure ancillary data socket option handling · edb50c0a

Mikio Hara authored Oct 04, 2014

This CL chops existing ancillary data socket option handlers and
puts them into platform dependent ancillary data socket option
binding table for code readability.

Fixes golang/go#6710.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/153860043

edb50c0a

03 Oct, 2014 2 commits

go.net/ipv4: restructure sticky socket option handling · 353547e1

Mikio Hara authored Oct 03, 2014

This CL chops existing sticky socket option handlers and puts them
into platform dependent sticky socket option binding table for
supporting multicast features such as source filtering for any-source
multicast, source-specific multicast.

Also adds tiny syscall shims to help to support solaris, to improve
existing platform support.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/140640045

353547e1

go.net/ipv4: rename payload_noncmsg.go to payload_nocmsg.go · 2604a58c
Mikio Hara authored Oct 03, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/154770043
```
2604a58c

24 Sep, 2014 1 commit
- go.net/internal/icmp: make sure IPv6PseudoHeader takes only IPv6 addresses · 4dee47b4
  Mikio Hara authored Sep 24, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/142540044
```
  4dee47b4
23 Sep, 2014 2 commits

go.net/internal/icmp: fix reordered arguments in test case · cb96e72d
Mikio Hara authored Sep 23, 2014
```
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/146210043
```
cb96e72d

go.net/internal/icmp: new package · 8916b1d9

Mikio Hara authored Sep 23, 2014

This CL factors out ICMP utilities used by both ipv4 and ipv6 packages.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/143460043

8916b1d9

22 Sep, 2014 1 commit

go.net/ipv4: fix build with go1.2 · 95f09c64

Mikio Hara authored Sep 22, 2014

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews
https://golang.org/cl/146890043

95f09c64

20 Sep, 2014 1 commit

go.net/internal/iana: new package · 27bf1b86

Mikio Hara authored Sep 20, 2014

This CL factors out number resources used by both ipv4 and ipv6 packages.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/124340043

27bf1b86

18 Sep, 2014 1 commit

go.net/ipv4: add platform-dependent code · b1072ec6

Mikio Hara authored Sep 18, 2014

The syscall package of standard library is now locked down
and go.sys/unix is under curation. Also go.sys/unix doesn't
help supporting go1.3 and earlier users. There's no way to
extend this package without holding the platform adaptation
code.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/146740043

b1072ec6

11 Aug, 2014 1 commit

context: make parentCancelCtx iterative · 84f8955a

Andrew Bursavich authored Aug 11, 2014

It seems like it was meant to be this way. There was already a for loop, but then it made a recursive call instead.

LGTM=sameer
R=golang-codereviews, sameer
CC=golang-codereviews
https://golang.org/cl/113540044

84f8955a

01 Aug, 2014 1 commit

context: provide String methods. The Strings show the functions called · 9c40a72a

Sameer Ajmani authored Aug 01, 2014

to construct the context left-to-right.  External implementations of the
Context interface may break the chain, but establishing this pattern now
may encourage them to do the right thing.

LGTM=bcmills
R=bcmills
CC=golang-codereviews
https://golang.org/cl/116430044

9c40a72a

30 Jul, 2014 2 commits

context: fix small leak introduced by reordering. · 983e15c9
Sameer Ajmani authored Jul 30, 2014
```
LGTM=bcmills
R=bcmills
CC=golang-codereviews
https://golang.org/cl/116420045
```
983e15c9

go.net/context: split the implementations of Background, WithValue, · a67aa996

Sameer Ajmani authored Jul 30, 2014

WithCancel, and WithTimeout to use different concrete types.  Update the
tests and documentation.

This change reduces the size of context structs, reduces the number of
allocations (see TestAllocs) and removes unnecessary pointers from the
heap, such as the timer field for non-timer contexts.

IMPORTANT: I've removed the code in these functions that handles nil Context parameters.  Passing a nil parent Context will now cause a panic.

LGTM=bcmills
R=bcmills, crawshaw
CC=adonovan, golang-codereviews, rsc
https://golang.org/cl/116400043

a67aa996

29 Jul, 2014 1 commit

go.net/context: define an emptyCtx type for Background and TODO. · a1f3609e

Sameer Ajmani authored Jul 29, 2014

This is the first step in splitting the various context implementations
into smaller types.

Add a test that creates a large, random stack of Contexts and tests that
they work properly.

LGTM=crawshaw
R=crawshaw
CC=golang-codereviews
https://golang.org/cl/115350044

a1f3609e

24 Jul, 2014 1 commit

go.net/context: update some comments, add a TODO. · 8734c452

Sameer Ajmani authored Jul 24, 2014

Use consistent spelling.

LGTM=bcmills
R=bcmills
CC=golang-codereviews
https://golang.org/cl/117170044

8734c452

23 Jul, 2014 1 commit
- go.net/publicsuffix: update table to latest list from publicsuffix.org. · 2d7673cd
  Nigel Tao authored Jul 23, 2014
```
LGTM=dr.volker.dobler
R=dr.volker.dobler
CC=golang-codereviews
https://golang.org/cl/116080045
```
  2d7673cd
10 Jul, 2014 1 commit

go.net/context: remove the Key type; replace it with interface{}. This · bf13cf4e

Sameer Ajmani authored Jul 10, 2014

makes the Context interface dependent only on standard packages, which
means types in other packages can implement this interface without
depending on go.net/context.

Remove the NewKey function and add examples showing how to use
unexported types to avoid key collisions.  This is the same model used
by http://www.gorillatoolkit.org/pkg/context, except we associate values
with a specific Context instead of storing them in a package-level map.

LGTM=crawshaw
R=golang-codereviews, crawshaw, dsymonds
CC=golang-codereviews, rsc
https://golang.org/cl/104480044

bf13cf4e

18 Jun, 2014 1 commit

go.net/context: adjust TestAlloc so it passes on windows · 6b9623cc

Alex Brainman authored Jun 18, 2014

Do not assume that a particular code path is selected
in WithTimeout.

Also Windows cannot wait for less then 15 millisecond,
so use that instead of 1 nanosecond in test. Otherwise
test takes too long while it looks like it is quick.

Fixes golang/go#8033.

LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://golang.org/cl/103470044

6b9623cc

12 Jun, 2014 1 commit

go.net/html: Fix comment handling for "in select" insertion mode · 5755bc4e

Frederick Kelly Mayle III authored Jun 12, 2014

LGTM=andybalholm, nigeltao
R=golang-codereviews, gobot, nigeltao, andybalholm
CC=golang-codereviews
https://golang.org/cl/93680045

5755bc4e

22 May, 2014 1 commit

netutil: release semaphore on error · a479876f

Brad Fitzpatrick authored May 22, 2014

Also rewrite it a bit for clarity (IMO).

LGTM=pzm, r
R=pzm, adg, r
CC=golang-codereviews
https://golang.org/cl/96560043

a479876f

21 May, 2014 2 commits

go.net/ipv6: add stubs for nacl build · 1e5c0004

Mikio Hara authored May 21, 2014

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/98440046

1e5c0004

go.net/ipv4: add stubs for nacl build · c6460483

Mikio Hara authored May 21, 2014

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/95560048

c6460483

20 May, 2014 1 commit

go.net/ipv4: diable the use of ip_mreqn on freebsd · 786e9ff9

Mikio Hara authored May 20, 2014

This CL disables the use of ip_mreqn with IP_{ADD,DROP}_MEMBERSHIP on
FreeBSD due to some test flakiness on some kernel versions that support
IGMPv3. It will be fixed once we support IGMPv3 related features such
as source-specific multicasting and source filtering.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/94670043

786e9ff9