• Brad Fitzpatrick's avatar
    http2: fix handling of errors from the readFrames goroutine · 271cfc1e
    Brad Fitzpatrick authored
    There was a design problem earlier where the serve goroutine assumed
    that the readFrame goroutine could return only connection-level
    errors, but the readFrames goroutine (and the underlying Framer)
    assumed it could return stream-level errors (type StreamError) and
    have them handled as stream errors in the layers above. That's how it
    should have been, and what this CL does.
    
    Now readFrames returns both the Frame and error from ReadFrames
    together as a pair, and an error isn't necessarily fatal to the
    connection.
    
    Fixes golang/go#12733
    Fixes bradfitz/http2#53
    
    Change-Id: If4406ceaa019886893d3c61e6bfce25ef74560d3
    Reviewed-on: https://go-review.googlesource.com/15735Reviewed-by: 's avatarDmitry Vyukov <dvyukov@google.com>
    271cfc1e
Name
Last commit
Last update
context Loading commit data...
dict Loading commit data...
html Loading commit data...
http2 Loading commit data...
icmp Loading commit data...
idna Loading commit data...
internal Loading commit data...
ipv4 Loading commit data...
ipv6 Loading commit data...
netutil Loading commit data...
proxy Loading commit data...
publicsuffix Loading commit data...
trace Loading commit data...
webdav Loading commit data...
websocket Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README Loading commit data...
codereview.cfg Loading commit data...