Commit 30de6d19 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick

unix: fix TestGetfsstat the same way as CL 28550 in pkg syscall

Same as https://golang.org/cl/28550 but for x/sys/unix.

Updates golang/go#16937

Change-Id: Ie93df8ff1c40a7f2d98f1fb3ecf6110330bf1cbc
Reviewed-on: https://go-review.googlesource.com/28585Reviewed-by: 's avatarJosh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
parent a646d33e
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
package unix_test package unix_test
import ( import (
"os/exec"
"runtime" "runtime"
"testing" "testing"
...@@ -14,23 +15,37 @@ import ( ...@@ -14,23 +15,37 @@ import (
) )
const MNT_WAIT = 1 const MNT_WAIT = 1
const MNT_NOWAIT = 2
func TestGetfsstat(t *testing.T) { func TestGetfsstat(t *testing.T) {
n, err := unix.Getfsstat(nil, MNT_WAIT) const flags = MNT_NOWAIT // see golang.org/issue/16937
n, err := unix.Getfsstat(nil, flags)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
data := make([]unix.Statfs_t, n) data := make([]unix.Statfs_t, n)
n, err = unix.Getfsstat(data, MNT_WAIT) n2, err := unix.Getfsstat(data, flags)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
if n != n2 {
empty := unix.Statfs_t{} t.Errorf("Getfsstat(nil) = %d, but subsequent Getfsstat(slice) = %d", n, n2)
for _, stat := range data { }
if stat == empty { for i, stat := range data {
t.Fatal("an empty Statfs_t struct was returned") if stat == (unix.Statfs_t{}) {
t.Errorf("index %v is an empty Statfs_t struct", i)
}
}
if t.Failed() {
for i, stat := range data[:n2] {
t.Logf("data[%v] = %+v", i, stat)
}
mount, err := exec.Command("mount").CombinedOutput()
if err != nil {
t.Logf("mount: %v\n%s", err, mount)
} else {
t.Logf("mount: %s", mount)
} }
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment